Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup stricter rules in our CI to prevent introduction of new flaky tests #24444

Open
9 tasks
hjetpoluru opened this issue May 8, 2024 · 2 comments
Open
9 tasks

Comments

@hjetpoluru
Copy link
Contributor

hjetpoluru commented May 8, 2024

What is this about?

Feedback from David Walsh

I guess making the driver APIs stricter?

Feedback from Legobeat

sounds good, but maybe just removing retries for a while will be a great start

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@gauthierpetetin gauthierpetetin changed the title Stricter rules Setup stricter rules in our CI to prevent introduction of new flaky tests Jun 26, 2024
@chloeYue
Copy link
Contributor

Close this ticket as we have introduced quality gate here: #24556

@hjetpoluru
Copy link
Contributor Author

hjetpoluru commented Jul 26, 2024

@chloeYue, This ticket was created to disable the retry button in CI, and to ensure that the testing driver API cannot be modified easily. Neither task has been completed yet. The quality gate you mentioned that newly created tests should be checked for flakiness that is implemented and close here. #24009

@hjetpoluru hjetpoluru reopened this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants