Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Customizing nonce with increment buttons adjusts nonce value to 0 or 1. #23535

Closed
sleepytanya opened this issue Mar 16, 2024 · 1 comment · Fixed by #26569
Closed

[Bug]: Customizing nonce with increment buttons adjusts nonce value to 0 or 1. #23535

sleepytanya opened this issue Mar 16, 2024 · 1 comment · Fixed by #26569
Assignees
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 Sev3-low Low severity; minimal to no impact upon users team-confirmations Push issues to confirmations team team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug

Comments

@sleepytanya
Copy link
Contributor

sleepytanya commented Mar 16, 2024

Describe the bug

When customizing nonce using lower increment button nonce value is set to 0, using higher increment button results in nonce = 1.

Expected behavior

Increment buttons should increase or decrease the suggested nonce by 1.

Screenshots/Recordings

Screen.Recording.2024-03-15.at.11.50.40.PM.mov

Steps to reproduce

  1. Go to 'Settings' -> 'Advanced'
  2. Turn 'Customize transaction nonce' toggle ON
  3. Start a 'Send' transaction
  4. Try to use increment buttons to customize transaction nonce on confirmation page

Error messages or log output

No response

Version

11.10.1, 11.13.0

Build type

None

Browser

Chrome, Firefox

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@sleepytanya sleepytanya added type-bug Sev3-low Low severity; minimal to no impact upon users labels Mar 16, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by severity Mar 16, 2024
@anaamolnar anaamolnar added the team-confirmations-system DEPRECATED: please use "team-confirmations" label instead label Mar 26, 2024
@cryptotavares cryptotavares added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead and removed team-confirmations-system DEPRECATED: please use "team-confirmations" label instead labels Mar 28, 2024
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Apr 9, 2024
@cryptotavares cryptotavares added the team-confirmations Push issues to confirmations team label Apr 24, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jul 23, 2024
@vinistevam vinistevam self-assigned this Aug 21, 2024
@github-actions github-actions bot removed the stale issues and PRs marked as stale label Aug 21, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by severity Sep 3, 2024
@github-project-automation github-project-automation bot moved this from To be fixed to Fixed in Bugs by team Sep 3, 2024
@metamaskbot metamaskbot added the release-12.6.0 Issue or pull request that will be included in release 12.6.0 label Sep 3, 2024
@gauthierpetetin gauthierpetetin added release-12.5.0 Issue or pull request that will be included in release 12.5.0 and removed release-12.6.0 Issue or pull request that will be included in release 12.6.0 labels Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-12.5.0 Issue or pull request that will be included in release 12.5.0 Sev3-low Low severity; minimal to no impact upon users team-confirmations Push issues to confirmations team team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants