Convert get-provider-state.js to Typescript #23469
Assignees
Labels
release-12.6.0
Issue or pull request that will be included in release 12.6.0
team-extension-platform
Comments
metamaskbot
added
the
INVALID-ISSUE-TEMPLATE
NiranjanaBinoy
removed
the
INVALID-ISSUE-TEMPLATE
13 tasks
github-merge-queue bot
pushed a commit
that referenced
this issue
Oct 2, 2024
Part of #23014 Fixes #23469 Converting the level 6 dependency file `app/scripts/lib/rpc-method-middleware/handlers/get-provider-state.js` to typescript for contributing to `metamask-controller.js`. ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/23635?quickstart=1) ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've clearly explained what problem this PR is solving and how it is solved. - [ ] I've linked related issues - [ ] I've included manual testing steps - [ ] I've included screenshots/recordings if applicable - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Jongsun Suh <[email protected]>
](https://codespaces.new/MetaMask/metamask-extension/pull/23635?quickstart=1){kind=link}
metamaskbot
added
the
release-12.6.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Part of #23014
Convert the dependency file
app/scripts/lib/rpc-method-middleware/handlers/get-provider-state.js(level 6) to typescript for contributing tometamask-controller.js.The text was updated successfully, but these errors were encountered: