Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: After triggering a Signautre, metrics events are sent non-stop until I confirm/cancel it #21738

Closed
seaona opened this issue Nov 8, 2023 · 1 comment · Fixed by #21743
Closed

[Bug]: After triggering a Signautre, metrics events are sent non-stop until I confirm/cancel it #21738

seaona opened this issue Nov 8, 2023 · 1 comment · Fixed by #21743
Assignees
@blackdevelopa
Labels
regression-prod-11.5.0 Regression bug that was found in production in release 11.5.0 release-11.5.0 Issue or pull request that will be included in release 11.5.0 release-11.6.0 Issue or pull request that will be included in release 11.6.0 release-blocker This bug is blocking the next release team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Nov 8, 2023

Describe the bug

Problem: whenever I trigger a signature, I can see how instead of 1 metrics event, they are sent infinetly events, until I close/confirm the signature.

This might be caused by to this PR, trying to capture the RPC requests https://github.com/MetaMask/metamask-extension/pull/21482/files

Expected behavior

Just 1 request should be sent after an action

Screenshots/Recordings

metrics-events-reqs.mp4

Steps to reproduce

  1. Open Segment on one window
  2. Start metamask
  3. Enable blockaid
  4. Select mainnet
  5. Trigger any signature
  6. See events sent non stop

Error messages or log output

No response

Version

11.5.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

Severity

No response
@seaona seaona added type-bug team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead release-blocker This bug is blocking the next release release-11.5.0 Issue or pull request that will be included in release 11.5.0 labels Nov 8, 2023
@metamaskbot metamaskbot added the regression-prod-11.5.0 Regression bug that was found in production in release 11.5.0 label Nov 8, 2023
@blackdevelopa blackdevelopa self-assigned this Nov 8, 2023
@segun
Copy link
Contributor

segun commented Nov 8, 2023

I found this issue while working on an e2e metric, so I fixed it in this PR
https://github.com/MetaMask/metamask-extension/pull/21708/files#diff-23ba5982fcc93dd2ef18d2889fe480da559dda4137e155f7f46edb793463d1b7

cc @blackdevelopa

@blackdevelopa blackdevelopa mentioned this issue Nov 8, 2023
Merged
13 tasks
@metamaskbot metamaskbot added the release-11.6.0 Issue or pull request that will be included in release 11.6.0 label Nov 9, 2023
@seaona seaona mentioned this issue Nov 22, 2023
Merged
@github-project-automation github-project-automation bot moved this to To be fixed in Bugs by team Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blackdevelopa blackdevelopa

Labels
regression-prod-11.5.0 Regression bug that was found in production in release 11.5.0 release-11.5.0 Issue or pull request that will be included in release 11.5.0 release-11.6.0 Issue or pull request that will be included in release 11.6.0 release-blocker This bug is blocking the next release team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix recurring signature metric event until I confirm/cancel it MetaMask/metamask-extension
4 participants
@segun @blackdevelopa @metamaskbot @seaona