Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: SIWE does not show Ledger dialog #18552

Closed
PeterYinusa opened this issue Apr 12, 2023 · 1 comment · Fixed by #18589
Closed

[Bug]: SIWE does not show Ledger dialog #18552

PeterYinusa opened this issue Apr 12, 2023 · 1 comment · Fixed by #18589
Assignees
@digiwand
Labels
regression-production release-10.29.0 Issue or pull request that will be included in release 10.29.0 release-blocker This bug is blocking the next release team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug

Comments

@PeterYinusa
Copy link
Contributor

PeterYinusa commented Apr 12, 2023 •
edited
Loading

Describe the bug

The following dialog is not displayed on the SIWE confirmation screen

Prior to clicking confirm:
- Plug in your Ledger device and select the Ethereum app
- Enable "smart contract data" or "blind signing" on your Ledger device
ledger.live.dialog.mov

Steps to reproduce

  1. log in to the extension
  2. connect a Ledger Hardware Wallet
  3. navigate to the test dapp
  4. Click Sign in with ethereum
    Ethereum

Error messages or log output

No response

Version

10.29

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

Ledger

Additional context

No response
@PeterYinusa PeterYinusa added type-bug team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead regression-production release-10.29.0 Issue or pull request that will be included in release 10.29.0 labels Apr 12, 2023
@danjm danjm added the release-blocker This bug is blocking the next release label Apr 13, 2023
@digiwand digiwand self-assigned this Apr 14, 2023
@digiwand digiwand mentioned this issue Apr 14, 2023
Merged
8 tasks
@digiwand
Copy link
Contributor

This appears to be an issue since Sign-in With Ethereum was released since the original implementation did not support this message

@digiwand digiwand mentioned this issue Apr 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@digiwand digiwand

Labels
regression-production release-10.29.0 Issue or pull request that will be included in release 10.29.0 release-blocker This bug is blocking the next release team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

SIWE | Sign-in With Ethereum - Add Ledger Instructions MetaMask/metamask-extension
3 participants
@danjm @digiwand @PeterYinusa