Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable eth_sign by default #17491

Closed
holantonela opened this issue Jan 30, 2023 · 0 comments · Fixed by #17308
Closed

Disable eth_sign by default #17491

holantonela opened this issue Jan 30, 2023 · 0 comments · Fixed by #17308
Assignees
Labels
area-signatures team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-security

Comments

@holantonela
Copy link

holantonela commented Jan 30, 2023

Background

After looking at various phishing kits (and de-obfuscating), there are enormous trends between different kits that they all abuse eth_sign to ask users to inadvertently sign a transaction (as MetaMask UI is opaque to an on-chain transaction being signed). You can read more about the attack here.

@409H'd estimate that the abuse of eth_sign is near equal to the abuse of Wyvern and Seaport contracts in a manner to steal NFTs through creating orders for 0 eth to a specific beneficiary.

In short: eth_sign has been consistently abused by phishers/scammers to steal funds and the case may be that only power-users who use very legacy dapps may need to still use eth_sign.

  • Disable eth_sign by default - throw an ethErrors.rpc.methodNotFound exception
  • Allow the user to enable eth_sign through "Advanced Settings"

RPC Method preferences are stored within rpcMethodPreferences in the store state, allow for us to develop this further if someone wants to lock down rpc calls into MetaMask.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-signatures team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-security
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants