Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Cannot navigate through multiple Sign prompts for Signed Typed Data V3 and V4 #16848

Closed
seaona opened this issue Dec 7, 2022 · 4 comments · Fixed by #17093
Closed
Assignees
Labels
PS-team PS MM extension team issues team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug

Comments

@seaona
Copy link
Contributor

seaona commented Dec 7, 2022

Describe the bug

Problem: we cannot navigate through multiple Sign prompts for Signed Typed Data V3 and V4. The expected behaviour is the one we see for Signed Type Data, Personal Sign and Eth Sign.

multiple-signs-typed-data.mp4

Steps to reproduce

  1. Connect to Test Dapp https://metamask.github.io/test-dapp/
  2. Click 3 times on Sign for Typed Data V4 -- see you cannot navigate through the multiple prompts nor Reject them all at once
  3. Reject one by one
  4. Click 3 times on Sign for Typed Data V3 -- see you cannot navigate through the multiple prompts nor Reject them all at once

Error messages or log output

No response

Version

10.24.0

Build type

None

Browser

Chrome

Operating system

Linux

Hardware wallet

No response

Additional context

No response

@seaona seaona added the type-bug label Dec 7, 2022
@bschorchit bschorchit added team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead PS-team PS MM extension team issues labels Dec 7, 2022
@ElvirCe
Copy link

ElvirCe commented Dec 8, 2022

@bschorchit I believe that this is not a bug as it is currently how it works on the production. @bschorchit can you please confirm and if we need to change and add a switch option we will need to determine the steps and acceptance criteria.

@bschorchit
Copy link

@bschorchit I believe that this is not a bug as it is currently how it works on the production. @bschorchit can you please confirm and if we need to change and add a switch option we will need to determine the steps and acceptance criteria.

I confirm this is something we want to change :)
The change should be the same we're doing here #16822 and here #16832 and be applied to all signature requests (Eth Sign, Personal Sign and all versions of SignTypedData).

@ElvirCe
Copy link

ElvirCe commented Dec 14, 2022

Expected behavior:

  1. Click 2 or more times on Sign for Typed Data V4:
  • The users should be able to navigate between multiple sign prompts back and forth
  • The users should be able to reject all sign prompts at once
  1. Click 2 or more times on Sign for Typed Data V3:
  • The users should be able to navigate between multiple sign prompts back and forth
  • The users should be able to reject all sign prompts at once
  1. Both options, Reject All and Switching Between Sign Attempts, should be available in combination, i.e. user clicked 2 times on Typed Data V4 and 2 times on Typed Data V3.
  2. Do the same steps as above for Eth Sign, Personal Sign and SignTypedData

Image

Image

@bschorchit
Copy link

Thank you for adding the detailed description, @ElvirCe ! Small comment: could we do it for Eth Sign, Personal Sign and SignTypedData too besides SignTypedData_v3 and SignTypedData_v4?
Eth Sign, Personal Sign and SignTypedData already have the reject all part in the bottom, but they don't have the part to navigate between sign prompts at the top.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PS-team PS MM extension team issues team-confirmations-secure-ux DEPRECATED: please use "team-confirmations" label instead type-bug
Projects
None yet
5 participants
@bschorchit @seaona @VSaric @ElvirCe and others