Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MV3: Dapp Interactions Test Cases #16690

Open
4 tasks
hilvmason opened this issue Nov 25, 2022 · 3 comments
Open
4 tasks

MV3: Dapp Interactions Test Cases #16690

hilvmason opened this issue Nov 25, 2022 · 3 comments

Comments

@hilvmason
Copy link
Contributor

hilvmason commented Nov 25, 2022

  • Ensure user remains connected to a Dapp after service worker re-start

NOTE: Remove or replace previous test that is currently failing on the mv3 folder.

  • Ensure user can connect to various Dapps and remains connected to all of them after service worker re-start

  • Ensure dapp functionality is preserved after service worker re-start

  • Reenable mv3 tests running on the pipeline.

We are currently piping the test errors coming from the mv3 test script that runs in the PR pipeline for it to fail silently.

That bypass is made here.

@hilvmason hilvmason changed the title Dapp Interactions Testcases Dapp Interactions Test Cases Nov 25, 2022
@danjm danjm changed the title Dapp Interactions Test Cases MV3: Dapp Interactions Test Cases Feb 24, 2023
@tmashuang
Copy link
Contributor

tmashuang commented Mar 18, 2023

The current status of MV3 as of this comment pertaining to dapp interactions is that any dapp that sends transactions will break the user experience after restarting the service worker.

@danjm
Copy link
Contributor

danjm commented Apr 25, 2023

@gauthierpetetin
Copy link
Contributor

gauthierpetetin commented Nov 28, 2023

This ticket may no longer be required as if all goes well, we won't have to re-start service worker.
Google said service workers will not have to be restarted but this needs to be confirmed.
We'll keep this ticket open until we have more info about service worker persistence.
In case there are edge cases, where service workers get disconnected, we'll have to refine this ticket more, and test Extension behaviour when we kill the service worker manually.

We'll have more info once our E2E tests work with MV3: #21496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants