Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ext Nav] Create component: TextFieldBase #15099

Closed
8 tasks
georgewrmarshall opened this issue Jun 29, 2022 · 0 comments · Fixed by #16043
Closed
8 tasks

[Ext Nav] Create component: TextFieldBase #15099

georgewrmarshall opened this issue Jun 29, 2022 · 0 comments · Fixed by #16043
Assignees
@georgewrmarshall
Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension

Comments

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Jun 29, 2022 •
edited
Loading

Description

Create a reusable UI component for TextFieldBase

References

Figma Link
UI component guidelines
Styling guidelines
Testing guidelines: TBC

Files needed

  • index.js
  • index.scss
  • text-field-base.js
  • text-field.stories.js
  • text-field.test.js
  • README.mdx

Technical details

TBC

Acceptance criteria

  • Uses color, typography, shadows design tokens
  • Uses semantic html
  • PropTypes have descriptions
  • Has storybook story with controls
  • Has documentation in MDX
  • Has unit tests and 90% coverage
  • Works in Chrome and Firefox
  • Performance tested: no unnecessary re-renders or other performance concerns[
@georgewrmarshall georgewrmarshall added area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension IA/NAV labels Jun 29, 2022
@georgewrmarshall georgewrmarshall self-assigned this Aug 11, 2022
@georgewrmarshall georgewrmarshall mentioned this issue Sep 30, 2022
Merged
6 tasks
@georgewrmarshall georgewrmarshall changed the title [Ext Nav] Create component: InputBase [Ext Nav] Create component: TextFieldBase Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@georgewrmarshall georgewrmarshall

Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding TextFieldBase component MetaMask/metamask-extension
1 participant
@georgewrmarshall