Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ext Nav] Create component: ButtonBase #15087

Closed
8 tasks
georgewrmarshall opened this issue Jun 29, 2022 · 0 comments · Fixed by #15998
Closed
8 tasks

[Ext Nav] Create component: ButtonBase #15087

georgewrmarshall opened this issue Jun 29, 2022 · 0 comments · Fixed by #15998
Assignees
Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension

Comments

@georgewrmarshall
Copy link
Contributor

georgewrmarshall commented Jun 29, 2022

Description

Create a reusable UI component for ButtonBase

References

Figma component
UI component guidelines
Styling guidelines
Testing guidelines: TBC

Files needed

  • index.js
  • index.scss
  • button-base.js
  • button-base.stories.js
  • button-base.test.js
  • README.mdx

Technical details

TBC

Acceptance criteria

  • Uses color, typography, shadows design tokens
  • Uses semantic html
  • PropTypes have descriptions
  • Has storybook story with controls
  • Has documentation in MDX
  • Has unit tests and 90% coverage
  • Works in Chrome and Firefox
  • Performance tested: no unnecessary re-renders or other performance concerns
@georgewrmarshall georgewrmarshall added area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension IA/NAV labels Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-UI Relating to the user interface. team-design-system All issues relating to design system in Extension
Projects
None yet
2 participants