Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: notification for when a dapp try's to access the MM address #1508

Closed
frankiebee opened this issue May 26, 2017 · 4 comments
Closed
Labels

Comments

@frankiebee
Copy link
Contributor

It may be a nice feature to let users know if and when a dapp is trying to get your account info
Locking is a nice thing but i forget to lock all the time so having a either sub provider or a proxy trap on web3 to throw up a notification when web3.eth.getAccounts or web3.eth.accounts is used would be nice. And maybe this could be toggled in settings if you dont like this behavior
it could also help users understand that for dapps to get the address the account needs to be unlocked

@kumavis
Copy link
Member

kumavis commented May 26, 2017

Yeah I'd like to turn this into a login flow / request address access flow

@2-am-zzz 2-am-zzz added P3-soon area-provider Relating to the provider module. labels May 30, 2017
@2-am-zzz 2-am-zzz modified the milestones: ENS Integration, Core Maintenance May 30, 2017
@ghost
Copy link

ghost commented Jul 26, 2017

I'd prefer MetaMask to be locked for new websites, with access to the password manager to unlock. The simplest way to implement a login flow would be a message from the dapp on MetaMask's unlock screen.

@danfinlay
Copy link
Contributor

@willnwhite That's already on our roadmap as #714.

@cjeria cjeria removed this from the Core Maintenance milestone Jan 22, 2018
@bdresser
Copy link
Contributor

Addressed by EIP 1102

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants