New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing multiple versions of modules from bundle #15026

Closed

jpuri opened this issue Jun 23, 2022 · 1 comment

Labels

MV3

Contributor

jpuri commented Jun 23, 2022 •

edited

Loading

Quite a few modules are included in bundle multiple times. For instance

bn.js
BigNumber.js
readable-stream.js
ethereumjs-util

https://output.circle-artifacts.com/output/job/0b87725e-d9fa-4b1e-87c8-209ba5bb939a/artifacts/0/build-artifacts/source-map-explorer/background-3.html

https://output.circle-artifacts.com/output/job/0b87725e-d9fa-4b1e-87c8-209ba5bb939a/artifacts/0/build-artifacts/source-map-explorer/common-2.html

We should remove this duplications from bundle.

jpuri added the MV3 label

jpuri changed the title ~~Removing multiple imports of modules~~ Removing multiple versions of modules from bundle

Contributor

danjm commented Aug 15, 2022

I don't think we need this ticket as we also have #15531 #14889

I also don't think the effort of removing multiple ethereumjs-util instances is worth it, and not sure if it is possible

danjm closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment