Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metamask doesn't detect events. #1429

Closed
win2win opened this issue May 15, 2017 · 12 comments
Closed

Metamask doesn't detect events. #1429

win2win opened this issue May 15, 2017 · 12 comments
Labels
area-provider Relating to the provider module. type-bug

Comments

@win2win
Copy link

win2win commented May 15, 2017

I'm connecting to ropsten on my local node. If I connect Metamask to my local node, events are firing as expected. Once I connect to ropsten directly from Metamask, events don't fire anymore. I have also connected to infura's ropsten the same problem.

I run metamask inside Chrome.
Metamask version 3.6.4
Operating system Ubuntu 16.04 LTS.
geth version: 1.6.0-stabled

@kumavis
Copy link
Member

kumavis commented May 15, 2017

Once I connect to ropsten directly from Metamask

does this mean you are using a local ropsten node?

@kumavis
Copy link
Member

kumavis commented May 15, 2017

can you provide an example tx that was mined that triggered events that metamask did not catch?

@win2win
Copy link
Author

win2win commented May 15, 2017

Yes, I'm running geth on my computer connecting to ropsten.

Here is an example of transaction. https://ropsten.etherscan.io/tx/0x8ac0df072714a3111824a3aa4edc916b47f2339205784308440e46cdd691fff6

@kumavis
Copy link
Member

kumavis commented May 15, 2017

ok that seems correct -- seems like you should be getting logs back

can you reproduce and check for errors here
https://github.com/MetaMask/faq/blob/master/LOGS.md#background-logs-chrome

@win2win
Copy link
Author

win2win commented May 15, 2017

btw. the transactions on the Metamask transaction list appear as completed soon after.

@win2win
Copy link
Author

win2win commented May 15, 2017

Not sure which errors are relevant in the background page. I found these.

(node) warning: possible EventEmitter memory leak detected. 11 listeners added. Use emitter.setMaxListeners() to increase limit.

InternalError {message: "invalid argument 0: hex number has leading zero digits after 0x", code: -32603}

@kumavis
Copy link
Member

kumavis commented May 15, 2017

invalid argument 0: hex number has leading zero digits after 0x

@win2win ok thats the problem - we'll need to fix the block ref in the filter subprovider
https://github.com/MetaMask/provider-engine/blob/master/subproviders/filters.js#L255

@win2win
Copy link
Author

win2win commented May 15, 2017

Would this error not affect all the clients?
When do you expect fix to be available?

@kumavis
Copy link
Member

kumavis commented May 15, 2017

slightly older versions of geth dont enforce the hex block number so strictly
we'll likely publish the fix tomorrow

@danfinlay
Copy link
Contributor

We fixed this zero-prefixing bug once already, for a different parameter. We should get a list of the newly-strictly-enforced parameters so we don't keep getting issues like this. Reaching out to the geth team now.

@win2win
Copy link
Author

win2win commented May 15, 2017

Will be enough to reinstall metamask to get the fix?

@kumavis
Copy link
Member

kumavis commented May 15, 2017

metamask auto updates, you wont have to do anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-provider Relating to the provider module. type-bug
Projects
None yet
Development

No branches or pull requests

3 participants