Skip to content

Commit

Permalink
fix: add deprecated tag back to callBackgroundMethod (#25216)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Removed wrongly in
#21410, this PR aims
to add `deprecated` tag back to `callBackgroundMethod` for migration
purpose.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25216?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
DDDDDanica authored Jun 11, 2024
1 parent 4f7f8f0 commit fbd9bbd
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions ui/store/background-connection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ type CallbackMethod<R = unknown> = (error?: unknown, result?: R) => void;
* [Deprecated] Callback-style call to background method
* invokes promisifiedBackground method directly.
*
* @deprecated Use async `submitRequestToBackground` function instead.
* @param method - name of the background method
* @param [args] - arguments to that method, if any
* @param callback - Node style (error, result) callback for finishing the operation
Expand Down

0 comments on commit fbd9bbd

Please sign in to comment.