Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: flaky test
vault decrypt
due to SRP hold time (#25328)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** This fixes another point of flakiness for the vault decrypt test. The logs show: ``` [driver] Called 'holdMouseDownOnElement' with arguments [{"text":"Hold to reveal SRP","tag":"span"},2000] [driver] Called 'findElement' with arguments ["[data-testid=\"srp_text\"]"] Failure on testcase: 'undefined', for more information see the artifacts tab in CI ``` The problem is that the holding time is not long enough so the srp element cannot be found. To repro, you can make a small time for the holding, and you'll see you hit the error. For fixing it we increase the holding time so we make sure that we'll always hold it until the required amount of time, within any variation of ci environment https://github.com/MetaMask/metamask-extension/assets/54408225/3251f205-4802-4f88-bcee-5a93203119a0 - ci : https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/87595/workflows/a9d135e4-ecef-44b6-a564-e8e3ca6813b5/jobs/3210020/steps Fix: https://github.com/MetaMask/metamask-extension/assets/54408225/db882cfa-ca2e-4a18-9a15-c0b740def439 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25328?quickstart=1) ## **Related issues** Fixes: #25329 ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
- Loading branch information