From 5daf4c452a3c05acedb8c62639226ddc38bc310b Mon Sep 17 00:00:00 2001 From: MetaMask Bot Date: Wed, 4 Sep 2024 16:25:04 +0000 Subject: [PATCH 1/3] Version v12.1.3 --- CHANGELOG.md | 5 ++++- package.json | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 058856f36ae2..ea171965fc39 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] +## [12.1.3] + ## [12.1.2] ### Fixed - Fix Trezor signing and connecting accounts ([#26882](https://github.com/MetaMask/metamask-extension/pull/26882)) @@ -5010,7 +5012,8 @@ Update styles and spacing on the critical error page ([#20350](https://github.c - Added the ability to restore accounts from seed words. -[Unreleased]: https://github.com/MetaMask/metamask-extension/compare/v12.1.2...HEAD +[Unreleased]: https://github.com/MetaMask/metamask-extension/compare/v12.1.3...HEAD +[12.1.3]: https://github.com/MetaMask/metamask-extension/compare/v12.1.2...v12.1.3 [12.1.2]: https://github.com/MetaMask/metamask-extension/compare/v12.1.1...v12.1.2 [12.1.1]: https://github.com/MetaMask/metamask-extension/compare/v12.1.0...v12.1.1 [12.1.0]: https://github.com/MetaMask/metamask-extension/compare/v12.0.6...v12.1.0 diff --git a/package.json b/package.json index b4daa2d43977..3f63cd09d757 100644 --- a/package.json +++ b/package.json @@ -1,6 +1,6 @@ { "name": "metamask-crx", - "version": "12.1.2", + "version": "12.1.3", "private": true, "repository": { "type": "git", From 252176b1fe570c46b97b2abc460a3744574acc20 Mon Sep 17 00:00:00 2001 From: Jyoti Puri Date: Thu, 5 Sep 2024 00:47:16 +0530 Subject: [PATCH 2/3] cherry-pick: Updating @metamask/eth-json-rpc-middleware to version 14.0.1 to fix regression in typed sign requests (#26916) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## **Description** Type sign signature requests break if verifyingContract is not defined. ## **Related issues** Fixes: https://github.com/MetaMask/metamask-extension/issues/26908 ## **Manual testing steps** 1. Connect to a dapp 2. Ensure that Ethereum Mainnet is the selected chain for that dapp 3. Run this in the console: ``` await window.ethereum.request({ method: 'eth_signTypedData_v4', params: [ window.ethereum.selectedAddress, `{"types":{"EIP712Domain":[{"name":"name","type":"string"},{"name":"version","type":"string"},{"name":"chainId","type":"uint256"}],"Permit":[{"name":"owner","type":"address"},{"name":"spender","type":"address"},{"name":"value","type":"uint256"},{"name":"nonce","type":"uint256"},{"name":"deadline","type":"uint256"}]},"primaryType":"Permit","domain":{"name":"USD Coin","chainId":${1},"version":"2"},"message":{"owner":"${window.ethereum.selectedAddress}","spender":"0x1661F1B207629e4F385DA89cFF535C8E5Eb23Ee3","value":"1033366316628","nonce":1,"deadline":1678709555}}`, ], }) ``` ## **Screenshots/Recordings** ### **Before** ### **After** ## **Pre-merge author checklist** - [X] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [X] I've completed the PR template to the best of my ability - [X] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [X] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- package.json | 2 +- yarn.lock | 10 +++++----- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 3f63cd09d757..86691f321045 100644 --- a/package.json +++ b/package.json @@ -304,7 +304,7 @@ "@metamask/design-tokens": "^4.0.0", "@metamask/ens-controller": "^10.0.1", "@metamask/eth-json-rpc-filters": "^7.0.0", - "@metamask/eth-json-rpc-middleware": "^14.0.0", + "@metamask/eth-json-rpc-middleware": "^14.0.1", "@metamask/eth-ledger-bridge-keyring": "^2.0.1", "@metamask/eth-query": "^4.0.0", "@metamask/eth-sig-util": "^7.0.1", diff --git a/yarn.lock b/yarn.lock index 2ecf26a3c743..45a2098436e2 100644 --- a/yarn.lock +++ b/yarn.lock @@ -5139,9 +5139,9 @@ __metadata: languageName: node linkType: hard -"@metamask/eth-json-rpc-middleware@npm:^14.0.0": - version: 14.0.0 - resolution: "@metamask/eth-json-rpc-middleware@npm:14.0.0" +"@metamask/eth-json-rpc-middleware@npm:^14.0.1": + version: 14.0.1 + resolution: "@metamask/eth-json-rpc-middleware@npm:14.0.1" dependencies: "@metamask/eth-block-tracker": "npm:^11.0.1" "@metamask/eth-json-rpc-provider": "npm:^4.1.1" @@ -5154,7 +5154,7 @@ __metadata: klona: "npm:^2.0.6" pify: "npm:^5.0.0" safe-stable-stringify: "npm:^2.4.3" - checksum: 10/1b62b1b2f2cce21cc4d7c4ccaf33024552119f09258cad1af683c317b90a5bbbb33311e3cb22a44913032deb93876ffdcbd591ed0269043af560a7a50a8ea6d9 + checksum: 10/39beecb0d2be19854b132fd615aee1f29195602d3db902f52755260b26a2c37c0a91cd635a09d4dc16f922d32bb229003b338228ae29577c5151d880fad04637 languageName: node linkType: hard @@ -25274,7 +25274,7 @@ __metadata: "@metamask/eslint-config-typescript": "npm:^9.0.1" "@metamask/eslint-plugin-design-tokens": "npm:^1.1.0" "@metamask/eth-json-rpc-filters": "npm:^7.0.0" - "@metamask/eth-json-rpc-middleware": "npm:^14.0.0" + "@metamask/eth-json-rpc-middleware": "npm:^14.0.1" "@metamask/eth-ledger-bridge-keyring": "npm:^2.0.1" "@metamask/eth-query": "npm:^4.0.0" "@metamask/eth-sig-util": "npm:^7.0.1" From 301a87e6b33ad41428f34582a40c0c6cbb58b785 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Wed, 4 Sep 2024 17:12:40 -0230 Subject: [PATCH 3/3] chore: Update changelog for v12.1.3 (#26917) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit ## **Description** Update changelog for v12.1.3 [![Open in GitHub Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/26917?quickstart=1) ## **Related issues** N/A ## **Manual testing steps** N/A ## **Screenshots/Recordings** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index ea171965fc39..635bb2a7fa15 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,6 +7,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 ## [Unreleased] ## [12.1.3] +### Fixed +- Fix `eth_signTypedData` error when `verifyingContract` is not provided ([#26914](https://github.com/MetaMask/metamask-extension/pull/26914)) ## [12.1.2] ### Fixed