From 7279ea5b404f39857b1a43df5171058d7b37ffbf Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Fri, 7 Oct 2022 12:49:20 -0400 Subject: [PATCH] Use current version of the phishing warning page (#16123) We now use the `latest` tag for the phishing warning page, we now use the version that matches what we have in our manifest. This ensures that our phishing warning e2e tests match the behaviour of the production build, and it ensures that breaking changes to the phishing warning page don't impact users in production. --- development/build/scripts.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/development/build/scripts.js b/development/build/scripts.js index 3ccaace8e10d..1e2ec7957d66 100644 --- a/development/build/scripts.js +++ b/development/build/scripts.js @@ -30,6 +30,7 @@ const bifyModuleGroups = require('bify-module-groups'); const { streamFlatMap } = require('../stream-flat-map'); const { BuildType } = require('../lib/build-type'); const { generateIconNames } = require('../generate-icon-names'); +const phishingWarningManifest = require('../../node_modules/@metamask/phishing-warning/package.json'); const { BUILD_TARGETS, ENVIRONMENT } = require('./constants'); const { getConfig, getProductionConfig } = require('./config'); const { @@ -112,7 +113,7 @@ function getPhishingWarningPageUrl({ config, testing }) { if (!phishingWarningPageUrl) { phishingWarningPageUrl = testing ? 'http://localhost:9999/' - : 'https://metamask.github.io/phishing-warning/latest/'; + : `https://metamask.github.io/phishing-warning/v${phishingWarningManifest.version}/`; } // We add a hash/fragment to the URL dynamically, so we need to ensure it