From 63c72fcb2ed9f3b1dd5cc350b6d49b261378d3d1 Mon Sep 17 00:00:00 2001 From: Mark Stacey Date: Wed, 29 Jan 2020 12:53:08 -0400 Subject: [PATCH] Replace `debounce` package with `debounce` function from `lodash` These two functions differ slightly in options, but none of those options are being used by us, so in these cases they're functionally equivalent. They're even both descendants of the original `debounce` function from `underscore`. This was done to reduce the number of direct dependencies we have. It should not affect bundle size, as we still depend upon the `debounce` package transitively. --- app/scripts/metamask-controller.js | 2 +- package.json | 1 - ui/app/components/ui/mascot.js | 2 +- .../send/send-content/add-recipient/ens-input.component.js | 2 +- yarn.lock | 2 +- 5 files changed, 4 insertions(+), 5 deletions(-) diff --git a/app/scripts/metamask-controller.js b/app/scripts/metamask-controller.js index 9dc8f0b2c2fc..5bbc54ccda62 100644 --- a/app/scripts/metamask-controller.js +++ b/app/scripts/metamask-controller.js @@ -14,7 +14,7 @@ import ComposableObservableStore from './lib/ComposableObservableStore' import asStream from 'obs-store/lib/asStream' import AccountTracker from './lib/account-tracker' import RpcEngine from 'json-rpc-engine' -import debounce from 'debounce' +import { debounce } from 'lodash' import createEngineStream from 'json-rpc-middleware-stream/engineStream' import createFilterMiddleware from 'eth-json-rpc-filters' import createSubscriptionManager from 'eth-json-rpc-filters/subscriptionManager' diff --git a/package.json b/package.json index 5ecb412cbd9a..9ed2f491808a 100644 --- a/package.json +++ b/package.json @@ -83,7 +83,6 @@ "copy-to-clipboard": "^3.0.8", "currency-formatter": "^1.4.2", "d3": "^5.15.0", - "debounce": "1.1.0", "debounce-stream": "^2.0.0", "deep-freeze-strict": "1.1.1", "dnode": "^1.2.2", diff --git a/ui/app/components/ui/mascot.js b/ui/app/components/ui/mascot.js index 835290487791..db2037cdf385 100644 --- a/ui/app/components/ui/mascot.js +++ b/ui/app/components/ui/mascot.js @@ -1,7 +1,7 @@ import PropTypes from 'prop-types' import React, { createRef, Component } from 'react' import metamaskLogo from 'metamask-logo' -import debounce from 'debounce' +import { debounce } from 'lodash' export default class Mascot extends Component { static propTypes = { diff --git a/ui/app/pages/send/send-content/add-recipient/ens-input.component.js b/ui/app/pages/send/send-content/add-recipient/ens-input.component.js index bac9ab3e6c98..4efea98dea29 100644 --- a/ui/app/pages/send/send-content/add-recipient/ens-input.component.js +++ b/ui/app/pages/send/send-content/add-recipient/ens-input.component.js @@ -4,7 +4,7 @@ import c from 'classnames' import { isValidENSAddress, isValidAddress, isValidAddressHead } from '../../../../helpers/utils/util' import { ellipsify } from '../../send.utils' -import debounce from 'debounce' +import { debounce } from 'lodash' import copyToClipboard from 'copy-to-clipboard/index' import ENS from 'ethjs-ens' import networkMap from 'ethjs-ens/lib/network-map.json' diff --git a/yarn.lock b/yarn.lock index ca47f7d4e975..a5d373b0986f 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8549,7 +8549,7 @@ debounce-stream@^2.0.0: duplexer "^0.1.1" through "^2.3.6" -debounce@1.1.0, debounce@^1.0.0: +debounce@^1.0.0: version "1.1.0" resolved "https://registry.yarnpkg.com/debounce/-/debounce-1.1.0.tgz#6a1a4ee2a9dc4b7c24bb012558dbcdb05b37f408" integrity sha512-ZQVKfRVlwRfD150ndzEK8M90ABT+Y/JQKs4Y7U4MXdpuoUkkrr4DwKbVux3YjylA5bUMUj0Nc3pMxPJX6N2QQQ==