diff --git a/app/scripts/background.js b/app/scripts/background.js index 81728abd2f39..6a446279a874 100644 --- a/app/scripts/background.js +++ b/app/scripts/background.js @@ -455,7 +455,7 @@ function triggerUi () { * Opens a new browser tab for user confirmation */ function triggerUiInNewTab () { - extension.tabs.query({ active: true }, tabs => { + extension.tabs.query({ active: true }, () => { const tabIdsArray = Object.keys(openMetamaskTabsIDs) if (tabIdsArray.length) { extension.tabs.update(parseInt(tabIdsArray[0], 10), { 'active': true }, () => { diff --git a/development/states/confirm-sig-requests.json b/development/states/confirm-sig-requests.json index ae7f3454de41..a0f4cd470f49 100644 --- a/development/states/confirm-sig-requests.json +++ b/development/states/confirm-sig-requests.json @@ -23,6 +23,9 @@ "name": "Send Account 4" } }, + "abTests": { + "fullScreenVsPopup": "control" + }, "cachedBalances": {}, "conversionRate": 1200.88200327, "conversionDate": 1489013762, diff --git a/development/states/currency-localization.json b/development/states/currency-localization.json index dff527f5aca1..263ef89c57f1 100644 --- a/development/states/currency-localization.json +++ b/development/states/currency-localization.json @@ -23,6 +23,9 @@ "name": "Send Account 4" } }, + "abTests": { + "fullScreenVsPopup": "control" + }, "cachedBalances": {}, "unapprovedTxs": {}, "conversionRate": 19855, diff --git a/development/states/tx-list-items.json b/development/states/tx-list-items.json index 08d1cf263751..fa5e93c6cb1a 100644 --- a/development/states/tx-list-items.json +++ b/development/states/tx-list-items.json @@ -23,6 +23,9 @@ "name": "Send Account 4" } }, + "abTests": { + "fullScreenVsPopup": "control" + }, "cachedBalances": {}, "currentCurrency": "USD", "conversionRate": 1200.88200327, diff --git a/test/unit/migrations/037-test.js b/test/unit/migrations/037-test.js index 417323ea781c..fabfcffe60c8 100644 --- a/test/unit/migrations/037-test.js +++ b/test/unit/migrations/037-test.js @@ -28,17 +28,7 @@ describe('migration #37', () => { migration37.migrate(oldStorage) .then((newStorage) => { - try { - assert.deepEqual(newStorage.data.ABTestController, { - 'fullScreenVsPopup': 'control', - }) - } catch (e) { - assert.deepEqual(newStorage.data.ABTestController, { - abTests: { - 'fullScreenVsPopup': 'fullScreen', - }, - }) - } + assert(newStorage.data.ABTestController.abTests.fullScreenVsPopup.match(/control|fullScreen/)) done() }) .catch(done)