Skip to content

Commit

Permalink
fix: remove mmi tests from ci (#29201)
Browse files Browse the repository at this point in the history
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**
Remove all MMI tests
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/29201?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
  • Loading branch information
racitores authored Dec 13, 2024
1 parent e7e13d2 commit 3ef7b6b
Showing 1 changed file with 1 addition and 263 deletions.
264 changes: 1 addition & 263 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,18 +87,6 @@ aliases:
cat ${HOME}/project/.circleci/scripts/enable-vnc.sh >> ~/.bashrc
fi
# Check if MMI tests should run
- &check-mmi-trigger
name: Check if MMI tests should run
command: |
source mmi_trigger.env
if [ "${run_mmi_tests}" == "true" ]; then
echo "Running MMI tests"
else
echo "Skipping MMI tests"
circleci step halt
fi
workflows:
test_and_release:
when:
Expand All @@ -118,7 +106,6 @@ workflows:
- trigger-beta-build:
requires:
- prep-deps
- check-mmi-trigger
- prep-deps
- get-changed-files-with-git-diff:
filters:
Expand Down Expand Up @@ -148,9 +135,6 @@ workflows:
build-type: [main, beta, flask, mmi]
requires:
- prep-deps
- prep-build-mmi:
requires:
- prep-deps
- prep-build:
requires:
- prep-deps
Expand Down Expand Up @@ -179,14 +163,6 @@ workflows:
<<: *main_master_rc_only
requires:
- prep-deps
- prep-build-test-mmi:
requires:
- prep-deps
- check-mmi-trigger
- prep-build-test-mmi-playwright:
requires:
- prep-deps
- check-mmi-trigger
- prep-build-storybook:
requires:
- prep-deps
Expand Down Expand Up @@ -236,20 +212,9 @@ workflows:
<<: *main_master_rc_only
requires:
- prep-build-test-flask-mv2
- test-e2e-chrome-mmi:
requires:
- prep-build-test-mmi
- get-changed-files-with-git-diff
- test-e2e-mmi-playwright:
requires:
- prep-build-test-mmi-playwright
- test-e2e-swap-playwright - OPTIONAL:
requires:
- prep-build
- test-e2e-chrome-rpc-mmi:
requires:
- prep-build-test-mmi
- get-changed-files-with-git-diff
- test-e2e-chrome-vault-decryption:
filters:
branches:
Expand All @@ -271,9 +236,6 @@ workflows:
- validate-source-maps-beta:
requires:
- trigger-beta-build
- validate-source-maps-mmi:
requires:
- prep-build-mmi
- validate-source-maps-flask:
requires:
- prep-build-flask
Expand Down Expand Up @@ -301,16 +263,13 @@ workflows:
- validate-source-maps
- validate-source-maps-beta
- validate-source-maps-flask
- validate-source-maps-mmi
- test-mozilla-lint-mv2
- test-mozilla-lint-flask-mv2
- test-e2e-chrome
- test-e2e-chrome-multiple-providers
- test-e2e-firefox
- test-e2e-chrome-flask
- test-e2e-firefox-flask
- test-e2e-chrome-mmi
- test-e2e-chrome-rpc-mmi
- test-e2e-chrome-vault-decryption
- test-e2e-chrome-webpack
- test-storybook
Expand All @@ -329,7 +288,6 @@ workflows:
- prep-build
- prep-build-mv2
- trigger-beta-build
- prep-build-mmi
- prep-build-flask
- prep-build-flask-mv2
- prep-build-storybook
Expand All @@ -346,7 +304,6 @@ workflows:
- prep-deps
- prep-build
- prep-build-mv2
- prep-build-mmi
- prep-build-flask
- prep-build-flask-mv2
- all-tests-pass
Expand Down Expand Up @@ -633,50 +590,6 @@ jobs:
- dist-mv2
- builds-mv2

prep-build-mmi:
executor: node-linux-medium
steps:
- run: *shallow-git-clone-and-enable-vnc
- run: corepack enable
- attach_workspace:
at: .
- when:
condition:
not:
matches:
pattern: /^master$/
value: << pipeline.git.branch >>
steps:
- run:
name: build:dist
command: yarn build --build-type mmi dist
- when:
condition:
matches:
pattern: /^master$/
value: << pipeline.git.branch >>
steps:
- run:
name: build:prod
command: yarn build --build-type mmi prod
- run:
name: build:debug
command: find dist/ -type f -exec md5sum {} \; | sort -k 2
- run:
name: Move mmi build to 'dist-mmi' to avoid conflict with production build
command: mv ./dist ./dist-mmi
- run:
name: Move mmi zips to 'builds-mmi' to avoid conflict with production build
command: mv ./builds ./builds-mmi
- persist_to_workspace:
root: .
paths:
- dist-mmi
- builds-mmi
- store_artifacts:
path: builds-mmi
destination: builds-mmi

prep-build-flask:
executor: node-linux-medium
steps:
Expand Down Expand Up @@ -803,57 +716,6 @@ jobs:
- dist-test-flask-mv2
- builds-test-flask-mv2

prep-build-test-mmi:
executor: node-linux-medium
steps:
- run: *shallow-git-clone-and-enable-vnc
- run: corepack enable
- attach_workspace:
at: .
- run: *check-mmi-trigger
- run:
name: Build extension for testing
command: yarn build:test:mmi
- run:
name: Move test build to 'dist-test' to avoid conflict with production build
command: mv ./dist ./dist-test-mmi
- run:
name: Move test zips to 'builds-test' to avoid conflict with production build
command: mv ./builds ./builds-test-mmi
- persist_to_workspace:
root: .
paths:
- dist-test-mmi
- builds-test-mmi

prep-build-test-mmi-playwright:
executor: node-linux-medium
steps:
- run: *shallow-git-clone-and-enable-vnc
- run: corepack enable
- attach_workspace:
at: .
- run: *check-mmi-trigger
- run:
name: Build MMI extension for Playwright e2e
command: |
export MMI_CONFIGURATION_SERVICE_URL=$MMI_DEV_CONFIGURATION_SERVICE_URL
yarn dist:mmi
- run:
name: Move test build to 'dist-test' to avoid conflict with production build
command: mv ./dist ./dist-test-mmi-playwright
- run:
name: Move test zips to 'builds-test' to avoid conflict with production build
command: mv ./builds ./builds-test-mmi-playwright
- persist_to_workspace:
root: .
paths:
- dist-test-mmi-playwright
- builds-test-mmi-playwright
- store_artifacts:
path: builds-test-mmi-playwright
destination: builds-test-mmi-playwright

prep-build-test:
executor: node-linux-medium
steps:
Expand Down Expand Up @@ -1198,30 +1060,6 @@ jobs:
- store_test_results:
path: test/test-results/e2e

test-e2e-chrome-rpc-mmi:
executor: node-browsers-medium
steps:
- run: *shallow-git-clone-and-enable-vnc
- run: sudo corepack enable
- attach_workspace:
at: .
- run: *check-mmi-trigger
- run:
name: Move test build to dist
command: mv ./dist-test-mmi ./dist
- run:
name: Move test zips to builds
command: mv ./builds-test-mmi ./builds
- run:
name: test:e2e:chrome:rpc
command: .circleci/scripts/test-run-e2e.sh yarn test:e2e:chrome:rpc --build-type=mmi
no_output_timeout: 5m
- store_artifacts:
path: test-artifacts
destination: test-artifacts
- store_test_results:
path: test/test-results/e2e

test-e2e-chrome-vault-decryption:
executor: node-browsers-medium-plus
steps:
Expand Down Expand Up @@ -1287,72 +1125,6 @@ jobs:
- store_test_results:
path: test/test-results/e2e

test-e2e-chrome-mmi:
executor: node-browsers-medium-plus
parallelism: 12
steps:
- run: *shallow-git-clone-and-enable-vnc
- run: sudo corepack enable
- attach_workspace:
at: .
- run: *check-mmi-trigger
- run:
name: Move test build to dist
command: mv ./dist-test-mmi ./dist
- run:
name: Move test zips to builds
command: mv ./builds-test-mmi ./builds
- run:
name: test:e2e:chrome:mmi
command: .circleci/scripts/test-run-e2e.sh yarn test:e2e:chrome:mmi --build-type=mmi
no_output_timeout: 5m
- store_artifacts:
path: test-artifacts
destination: test-artifacts
- store_test_results:
path: test/test-results/e2e

test-e2e-mmi-playwright:
executor: playwright
parallelism: 2
steps:
- run: *shallow-git-clone-and-enable-vnc
- run: corepack enable
- attach_workspace:
at: .
- run: *check-mmi-trigger
- run:
name: Move test build to dist
command: mv ./dist-test-mmi-playwright ./dist
- run:
name: Install chromium
command: yarn playwright install chromium
- run:
name: test:e2e:chrome:mmi
command: |
TESTFILES=$(circleci tests glob "test/e2e/playwright/mmi/**/*.spec.ts")
echo "$TESTFILES"
echo "$TESTFILES" | timeout 20m circleci tests run --command="xvfb-run xargs yarn playwright test --project=mmi" verbose --split-by=timings
no_output_timeout: 10m
- slack/notify:
branch_pattern: Version-v*
event: fail
mentions: <@antonio.regadas>, @ramon.acitores134
template: basic_fail_1
channel: C01LUJL3T98
- slack/notify:
branch_pattern: main
event: fail
mentions: <@antonio.regadas>, @ramon.acitores134
template: basic_fail_1
channel: C05QXJA7NP8
- store_artifacts:
name: html-report and artifacts
path: public/playwright/playwright-reports
- store_test_results:
name: report for pipeline integration
path: public/playwright/playwright-reports/junit/test-results.xml

test-e2e-swap-playwright - OPTIONAL:
executor: playwright
parallelism: 2
Expand Down Expand Up @@ -1524,9 +1296,7 @@ jobs:
- store_artifacts:
path: builds-flask-mv2
destination: builds-flask-mv2
- store_artifacts:
path: builds-mmi
destination: builds-mmi

- store_artifacts:
path: builds-mv2
destination: builds-mv2
Expand Down Expand Up @@ -1641,23 +1411,6 @@ jobs:
name: Validate source maps
command: .circleci/scripts/validate-source-maps-beta.sh

validate-source-maps-mmi:
executor: node-browsers-small
steps:
- run: *shallow-git-clone-and-enable-vnc
- run: sudo corepack enable
- attach_workspace:
at: .
- run:
name: Move mmi build to dist
command: mv ./dist-mmi ./dist
- run:
name: Move mmi zips to builds
command: mv ./builds-mmi ./builds
- run:
name: Validate source maps
command: yarn validate-source-maps

validate-source-maps-flask:
executor: node-browsers-small
steps:
Expand Down Expand Up @@ -1749,18 +1502,3 @@ jobs:
- run:
name: All Tests Passed
command: echo 'whew - everything passed!'

check-mmi-trigger:
executor: node-browsers-small
steps:
- checkout
- run:
name: Check for MMI Team Label or Reviewer
command: ./.circleci/scripts/check_mmi_trigger.sh
- store_artifacts:
path: mmi_trigger.env
destination: mmi_trigger.env
- persist_to_workspace:
root: .
paths:
- mmi_trigger.env

0 comments on commit 3ef7b6b

Please sign in to comment.