devDeps: bump `@metamask/eslint-config*` from v9 to `^12.1.0` #90

legobeat · 2023-09-01T04:05:17Z

Unblocks

Fix Node.js v18+ compatibility #94 (https://github.com/MetaMask/eth-json-rpc-infura/actions/runs/6045680395/job/16406100504?pr=92)
- Remove support for Node.js 14 #91
  - deps: Update eth-json-rpc and metamask packages #95
    - 9.0.0 #96
      - deps: Bump @metamask/{eth-json-rpc-provider,rpc-errors} core#1653
        
        deps: Update @metamask/utils and @metamask/rpc-errors snaps#1728

socket-security · 2023-09-01T04:06:42Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
eslint-plugin-promise	6.1.1	None	`+7`	2.8 MB	eslint-community-bot
eslint-plugin-n	15.7.0	filesystem	`+11`	3.41 MB	weiran.zsd
@metamask/eslint-config-jest	9.0.0...12.1.0	shell	`+113/-120`	83.1 MB	metamaskbot
@metamask/eslint-config-typescript	9.0.1...12.1.0	None	`+18/-119`	76 MB	metamaskbot
@metamask/eslint-config-nodejs	9.0.0...12.1.0	None	`+12/-112`	3.5 MB	metamaskbot
jest	26.6.3...28.1.3	None	`+97/-281`	76.1 MB	simenb
ts-jest	26.5.6...28.0.8	environment	`+99/-282`	76.4 MB	kul
@typescript-eslint/eslint-plugin	4.33.0...5.62.0	None	`+17/-64`	76 MB	jameshenry
@typescript-eslint/parser	4.33.0...5.62.0	None	`+12/-61`	72.9 MB	jameshenry
eslint-plugin-prettier	3.4.1...4.2.1	None	`+8/-57`	14 MB	jounqin
prettier	2.6.1...2.8.8	environment	`+0/-0`	11.2 MB	prettier-bot
eslint-plugin-jsdoc	36.1.1...43.0.7	None	`+11/-62`	5.18 MB	gajus
eslint-plugin-import	2.25.4...2.26.0	None	`+12/-99`	4.21 MB	ljharb
eslint-plugin-jest	24.7.0...27.2.3	shell	`+112/-65`	83.1 MB	simenb
typescript	4.4.4...4.8.4	None	`+0/-0`	68.8 MB	typescript-bot

🚮 Removed packages: @metamask/[email protected], [email protected], [email protected]

socket-security · 2023-09-01T04:06:45Z

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring: [email protected], [email protected], [email protected], @jridgewell/[email protected], [email protected], [email protected], [email protected], [email protected]

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

legobeat · 2023-09-11T13:14:05Z

@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

"obfuscated require" ok

Expected only 0 line after block description jsdoc/tag-lines

Fixes errors running tests under Node.js 20.

legobeat · 2023-09-20T02:27:54Z

@SocketSecurity ignore [email protected]

shell access ok

legobeat · 2023-09-20T02:28:14Z

@SocketSecurity ignore [email protected]

new author ok

legobeat · 2023-09-20T02:28:37Z

@SocketSecurity ignore @jridgewell/[email protected]
@SocketSecurity ignore [email protected]
@SocketSecurity ignore [email protected]

unmaintained ok

legobeat · 2023-09-20T02:30:03Z

@SocketSecurity ignore [email protected]

unmaintained ok

legobeat force-pushed the devDeps-eslint branch from c16eb6f to ce40a77 Compare September 1, 2023 04:05

legobeat added the dependencies Pull requests that update a dependency file label Sep 1, 2023

This comment was marked as resolved.

Sign in to view

legobeat marked this pull request as ready for review September 1, 2023 04:07

legobeat requested a review from a team as a code owner September 1, 2023 04:07

This was referenced Sep 1, 2023

Remove support for Node.js 14 #91

Merged

Fix Node.js v18+ compatibility #94

Closed

legobeat requested review from mcmire and a team September 4, 2023 23:55

This was referenced Sep 7, 2023

deps: Update eth-json-rpc and metamask packages #95

Merged

9.0.0 #96

Merged

deps: Bump @metamask/{eth-json-rpc-provider,rpc-errors} MetaMask/core#1653

Merged

legobeat force-pushed the devDeps-eslint branch from ce40a77 to b1cd23e Compare September 11, 2023 13:08

legobeat requested review from a team, Mrtenz and Gudahtt September 11, 2023 13:22

legobeat added 6 commits September 12, 2023 21:36

devDeps: bump @metamask/eslint-config to ^12.1.0

d7fb851

resolve peerDependencies requirements

6fab8b8

lint: disable stock eslint rule

4ceb6c2

lint:fix

412f687

lint:fix

53a96dc

yarn dedupe

e366343

legobeat force-pushed the devDeps-eslint branch from b1cd23e to e366343 Compare September 12, 2023 12:37

legobeat mentioned this pull request Sep 13, 2023

deps: Update @metamask/utils and @metamask/rpc-errors MetaMask/snaps#1728

Closed

34 tasks

legobeat requested a review from a team September 14, 2023 22:45

devDeps: @metamask/eslint-config@^12.1.0->12.2.0

e5a9bcd

legobeat added 3 commits September 16, 2023 07:10

ci: run on nodejs v18,v20

8dca80c

devDeps: eslint-plugin-jsdoc@^39.6.2->^43.0.7

a02d394

ci: skip lint step on yarn 14 only

7096753

legobeat force-pushed the devDeps-eslint branch from 6388e9f to 7096753 Compare September 15, 2023 22:51

legobeat added 2 commits September 18, 2023 18:02

devDeps: pin eslint-plugin-import,eslint-plugin-jsdoc

856e682

eslint:fix

5d88410

Expected only 0 line after block description jsdoc/tag-lines

legobeat force-pushed the devDeps-eslint branch from 86a41e2 to 5d88410 Compare September 18, 2023 09:04

legobeat added 2 commits September 18, 2023 18:13

devDeps: jest@^26.4.2->^28.1.3, ts-jest@^26.3.0->^28.0.8

e3fb60b

Fixes errors running tests under Node.js 20.

yarn dedupe

0afc797

legobeat requested a review from vinistevam September 18, 2023 09:17

kumavis approved these changes Sep 20, 2023

View reviewed changes

legobeat merged commit c45826e into MetaMask:main Sep 20, 2023
6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

devDeps: bump `@metamask/eslint-config*` from v9 to `^12.1.0` #90

devDeps: bump `@metamask/eslint-config*` from v9 to `^12.1.0` #90

legobeat commented Sep 1, 2023 •

edited

Loading

socket-security bot commented Sep 1, 2023 •

edited

Loading

socket-security bot commented Sep 1, 2023 •

edited

Loading

This comment was marked as resolved.

legobeat commented Sep 11, 2023

legobeat commented Sep 20, 2023

legobeat commented Sep 20, 2023

legobeat commented Sep 20, 2023

legobeat commented Sep 20, 2023

devDeps: bump @metamask/eslint-config* from v9 to ^12.1.0 #90

devDeps: bump @metamask/eslint-config* from v9 to ^12.1.0 #90

Conversation

legobeat commented Sep 1, 2023 • edited Loading

Unblocks

socket-security bot commented Sep 1, 2023 • edited Loading

socket-security bot commented Sep 1, 2023 • edited Loading

Next steps

This comment was marked as resolved.

legobeat commented Sep 11, 2023

legobeat commented Sep 20, 2023

legobeat commented Sep 20, 2023

legobeat commented Sep 20, 2023

legobeat commented Sep 20, 2023

devDeps: bump `@metamask/eslint-config*` from v9 to `^12.1.0` #90

devDeps: bump `@metamask/eslint-config*` from v9 to `^12.1.0` #90

legobeat commented Sep 1, 2023 •

edited

Loading

socket-security bot commented Sep 1, 2023 •

edited

Loading

socket-security bot commented Sep 1, 2023 •

edited

Loading