Refactor base-controller for type safety and better application of controller-messenger pattern

[MajorLift]

Motivation

The BaseController, ControllerMessenger, and RestrictedControllerMessenger classes outline the controller-messenger pattern that are implemented by all of our controllers.

However, these classes are currently limited by incomplete or unsafe typing, and weak enforcement of best practices. A rigorous overhaul of the types and methods defined in base-controller, along with updates to enable more accurate allowlisting of action and events, will unlock type-safe feature development for all of our clients and services.

These changes remove blockers for updating controllers to use BaseControllerV2, while completely deprecating BaseControllerV1. This affects all controllers slated to be consolidated and migrated into the core repo.

Tasks

• Fix all any usage.
  • ActionConstraint, ExtractActionParameters, ExtractActionResponse
  • SelectorFunction, EventSubscriptionMap
• Improve handling of namespaced type names.
• getState action and stateChange event are defined in the base controller.
• Enforce sound practices around action/event allow lists.
  • All internal actions/events are available for usage without being specified in an allow list.
  • Internal actions/events are not accepted into allow lists when a restricted controller-messenger is being initialized.

[MajorLift]

• Closed by Release 93.0.0 #2063