-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@metamask/json-rpc-{engine,middleware-stream}
- Create tags for release commits that were untagged in the pre-migration repo
#2002
Labels
Comments
10 tasks
|
5 tasks
MajorLift
changed the title
Nov 9, 2023
@metamask/json-rpc-engine
- Create tags for release commits that were untagged in the pre-migration repo@metamask/json-rpc-{engine,middleware-stream}
- Create tags for release commits that were untagged in the pre-migration repo
|
Closing as COMPLETED |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Explanation
While migrating
@metamask/json-rpc-engine
and@metamask/json-rpc-middleware-stream
into the core repo, some earlier release commits that were untagged in the original repo were skipped by the tag porting script. These need to be tagged manually.TODO: GitHub may show these manually-created tags out of order due to sorting by tag creation date instead of release commit timestamp.Updateautochange-log
so that it's validator accepts tag diff links for manually-created tags that may not be under the@metamask/
namespace.References
eth-json-rpc-provider
into core monorepo #1551 (comment) for an outline of the migration process.@metamask/json-rpc-engine
#1981The text was updated successfully, but these errors were encountered: