Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate @metamask/eth-json-rpc-provider - Phase B: Staging from merged-packages/ #1792

Closed
15 tasks done
MajorLift opened this issue Oct 5, 2023 · 0 comments
Closed
15 tasks done
Assignees
Labels

Comments

@MajorLift
Copy link
Contributor

MajorLift commented Oct 5, 2023

As part of the process for migrating @metamask/eth-json-rpc-provider into the core monorepo, we need to execute various preparation steps while the package is inside of the temporary merged-packages/ directory, before it can be moved into the packages/ directory.

See #1551 (comment) for an outline of the entire process.


Phase B: Staging from merged-packages/

1. Remove files and directories that will be replaced by files in the monorepo root.

2. Replace config files.

  • eth-json-rpc-provider migration - B2: Replace typescript, jest config files. #1765
    • Update tsconfig*.json, typedoc.json, jest.config.js to extend from corresponding files in root. Copy contents of corresponding files in other non-root packages.
    • Keep TypeScript compiler flags.
    • Add tsconfig reference paths for non-root packages that are upstream dependencies of the migration target.
    • Keep Jest coverage threshold values.
    • Add deepmerge as a devDependency.

3. Align dependencies with monorepo.

4. Add exception for non-MIT license.

@MajorLift MajorLift self-assigned this Oct 5, 2023
@MajorLift MajorLift reopened this Oct 5, 2023
@MajorLift MajorLift reopened this Oct 5, 2023
@MajorLift MajorLift reopened this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant