Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate json-rpc-middleware-stream to Yarn v3 #1678

Closed
mikesposito opened this issue Sep 15, 2023 · 0 comments
Closed

Migrate json-rpc-middleware-stream to Yarn v3 #1678

mikesposito opened this issue Sep 15, 2023 · 0 comments
Assignees

Comments

@mikesposito
Copy link
Member

The json-rpc-middleware-stream package (https://github.com/MetaMask/json-rpc-middleware-stream) should be migrated to Yarn v3, to match our module template.

From MetaMask/eth-ledger-bridge-keyring#165:

  • Run yarn set version stable to install Yarn v3.
  • Copy .yarnrc.yml and .yarn/plugins from the module template.
  • Run yarn install to generate a new version of yarn.lock.
  • As our Yarn v3 assumes that @lavamoat/allow-scripts is installed, we will want to add that as a development dependency. In addition, we will want to add a lavamoat section to package.json. Again, see the module template for the correct version of allow-scripts to use as well as where the new lavamoat section should go.

Similar PRs:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants