Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align keyrings destroy / dispose API #1428

Open
2 of 4 tasks
mikesposito opened this issue Jun 15, 2023 · 0 comments
Open
2 of 4 tasks

Align keyrings destroy / dispose API #1428

mikesposito opened this issue Jun 15, 2023 · 0 comments

Comments

@mikesposito
Copy link
Member

mikesposito commented Jun 15, 2023

Currently, the type we use for Keyrings does not include a "destroy" function. On the other hand, Ledger and Trezor keyring have a function for this and is named dispose for Trezor and destroy for Ledger.

At the moment Ledger and Trezor keyrings are not implementing the Keyring type, but would be beneficial to:

See also original discussion: MetaMask/KeyringController#233 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant