Skip to content
Back to pull request #4995

maybe simplify error handling in RemoteFeatureFlagController #13591

Sign in to view logs

maybe simplify error handling in RemoteFeatureFlagController

maybe simplify error handling in RemoteFeatureFlagController #13591

Triggered via pull request November 27, 2024 20:47
@danjmdanjm
opened #4995
origin/feature/27254-feature-flag-controller/error-handling-patch
Status Failure
Total duration 3m 57s
Artifacts –

main.yml

on: pull_request
Check workflows
4s
Check workflows
Matrix: Lint, build, and test / Prepare
Matrix: Lint, build, and test / Build
Matrix: Lint, build, and test / Lint
Matrix: Lint, build, and test / Test
Matrix: Lint, build, and test / Validate changelog
Determine whether this is a release merge commit
0s
Determine whether this is a release merge commit
All jobs complete
0s
All jobs complete
Publish release  /  publish-release
Publish release / publish-release
All jobs pass
0s
All jobs pass
Publish release  /  publish-npm-dry-run
Publish release / publish-npm-dry-run
Publish release  /  publish-npm
Publish release / publish-npm
Create update issues  /  create-update-issues
Create update issues / create-update-issues
Fit to window
Zoom out
Zoom in

Annotations

11 errors
Lint, build, and test / Lint (20.x): packages/remote-feature-flag-controller/src/client-config-api-service/client-config-api-service.test.ts#L70
'remoteFeatureFlag' is assigned a value but never used
Lint, build, and test / Lint (20.x): packages/remote-feature-flag-controller/src/client-config-api-service/client-config-api-service.test.ts#L71
'cacheTimestamp' is assigned a value but never used
Lint, build, and test / Lint (20.x): packages/remote-feature-flag-controller/src/client-config-api-service/client-config-api-service.test.ts#L73
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
Lint, build, and test / Lint (20.x): packages/remote-feature-flag-controller/src/client-config-api-service/client-config-api-service.test.ts#L73
Async assertions must be awaited
Lint, build, and test / Lint (20.x): packages/remote-feature-flag-controller/src/client-config-api-service/client-config-api-service.test.ts#L73
Replace `networkError` with `⏎······networkError,⏎····`
Lint, build, and test / Lint (20.x): packages/remote-feature-flag-controller/src/client-config-api-service/client-config-api-service.test.ts#L88
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
Lint, build, and test / Lint (20.x): packages/remote-feature-flag-controller/src/client-config-api-service/client-config-api-service.test.ts#L88
Async assertions must be awaited
Lint, build, and test / Lint (20.x): packages/remote-feature-flag-controller/src/client-config-api-service/client-config-api-service.test.ts#L88
Replace `networkError` with `⏎······networkError,⏎····`
Lint, build, and test / Lint (20.x): packages/remote-feature-flag-controller/src/client-config-api-service/client-config-api-service.test.ts#L108
Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator
Lint, build, and test / Lint (20.x): packages/remote-feature-flag-controller/src/client-config-api-service/client-config-api-service.test.ts#L108
Async assertions must be awaited
All jobs pass
Process completed with exit code 1.