-
-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update ERC20Standard to use @metamask/abi-utils
instead of @ethersproject/abi
#985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonesky1
force-pushed
the
replace-abi-decoder
branch
4 times, most recently
from
November 22, 2022 17:39
b300419
to
c133fed
Compare
adonesky1
changed the title
update ERC20Standard to use instead of
update ERC20Standard to use Dec 6, 2022
@metamask/abi-utils
instead of @ethersproject/abi
adonesky1
force-pushed
the
replace-abi-decoder
branch
from
December 6, 2022 20:09
c133fed
to
85607ed
Compare
adonesky1
force-pushed
the
replace-abi-decoder
branch
from
December 6, 2022 20:47
e12237c
to
f047e31
Compare
adonesky1
force-pushed
the
replace-abi-decoder
branch
from
December 6, 2022 22:21
f047e31
to
0cc437d
Compare
Mrtenz
previously requested changes
Dec 7, 2022
mcmire
reviewed
Dec 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, but otherwise makes sense to me.
FrederikBolding
approved these changes
Dec 21, 2022
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…project/abi` (#985) Resolves MetaMask/metamask-extension#16567 Co-authored-by: Maarten Zuidhoorn <[email protected]>
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
…project/abi` (#985) Resolves MetaMask/metamask-extension#16567 Co-authored-by: Maarten Zuidhoorn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves MetaMask/metamask-extension#16567