Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update ERC20Standard to use @metamask/abi-utils instead of @ethersproject/abi #985

Merged
merged 14 commits into from
Dec 21, 2022

Conversation

adonesky1
Copy link
Contributor

@adonesky1 adonesky1 commented Nov 22, 2022

@adonesky1 adonesky1 force-pushed the replace-abi-decoder branch 4 times, most recently from b300419 to c133fed Compare November 22, 2022 17:39
@adonesky1 adonesky1 changed the title update ERC20Standard to use instead of update ERC20Standard to use @metamask/abi-utils instead of @ethersproject/abi Dec 6, 2022
@adonesky1 adonesky1 force-pushed the replace-abi-decoder branch from c133fed to 85607ed Compare December 6, 2022 20:09
@adonesky1 adonesky1 force-pushed the replace-abi-decoder branch from e12237c to f047e31 Compare December 6, 2022 20:47
@adonesky1 adonesky1 marked this pull request as ready for review December 6, 2022 20:47
@adonesky1 adonesky1 requested a review from a team as a code owner December 6, 2022 20:47
@adonesky1 adonesky1 requested a review from Mrtenz December 6, 2022 20:47
@adonesky1 adonesky1 force-pushed the replace-abi-decoder branch from f047e31 to 0cc437d Compare December 6, 2022 22:21
Mrtenz
Mrtenz previously requested changes Dec 7, 2022
packages/assets-controllers/jest.environment.js Outdated Show resolved Hide resolved
packages/assets-controllers/package.json Show resolved Hide resolved
packages/assets-controllers/src/Standards/ERC20Standard.ts Outdated Show resolved Hide resolved
packages/assets-controllers/src/Standards/ERC20Standard.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, but otherwise makes sense to me.

@adonesky1 adonesky1 merged commit 6892d76 into main Dec 21, 2022
@adonesky1 adonesky1 deleted the replace-abi-decoder branch December 21, 2022 16:44
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace use of @ethersproject/abi (decode method) with internal version from @metamask/abi-utils
4 participants