Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 34.0.0 #960

Merged
merged 7 commits into from
Nov 21, 2022
Merged

Release 34.0.0 #960

merged 7 commits into from
Nov 21, 2022

Conversation

mcmire
Copy link
Contributor

@mcmire mcmire commented Nov 15, 2022 •
edited
Loading

This release includes initial releases for all new packages.

The release notes will end up being something like:

34.0.0

@metamask/announcement-controller

Added

  • Initial release

    • As a result of converting our shared controllers repo into a monorepo (#831), we've created this package from select parts of @metamask/controllers v33.0.0, namely:

      • src/user/AddressBookController.ts
      • src/user/AddressBookController.test.ts

      All changes listed after this point were applied to this package following the monorepo conversion.

@metamask/address-book-controller

Added

  • Initial release

    • As a result of converting our shared controllers repo into a monorepo (#831), we've created this package from select parts of @metamask/controllers v33.0.0, namely:

      • Everything in src/announcement

      All changes listed after this point were applied to this package following the monorepo conversion.

...

@mcmire
Copy link
Contributor Author

mcmire commented Nov 15, 2022

Currently blocked on MetaMask/auto-changelog#130.

@mcmire
Copy link
Contributor Author

mcmire commented Nov 15, 2022

Blocked on MetaMask/auto-changelog#131.

@mcmire mcmire marked this pull request as ready for review November 16, 2022 17:15
@mcmire mcmire requested a review from a team as a code owner November 16, 2022 17:15
Gudahtt
Gudahtt reviewed Nov 16, 2022
View reviewed changes
package.json Show resolved Hide resolved
@mcmire mcmire changed the title Release 34.0.0 Release 34.0.0-rc.1 Nov 16, 2022
@mcmire mcmire changed the title Release 34.0.0-rc.1 Release 34.0.0 Nov 16, 2022
@mcmire mcmire marked this pull request as draft November 16, 2022 19:50
@mcmire
Copy link
Contributor Author

mcmire commented Nov 16, 2022

Putting this back in draft until we are truly ready to merge this.

@mcmire
Release 34.0.0
f2fa748 
This release includes initial releases for all new packages.
@mcmire
Copy link
Contributor Author

mcmire commented Nov 16, 2022

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Packages published as '[current-version]-f2fa748'

@mcmire
Copy link
Contributor Author

mcmire commented Nov 16, 2022

Testing new packages out on extension: MetaMask/metamask-extension#16547

@mcmire mcmire mentioned this pull request Nov 17, 2022
Merged
8 tasks
@mcmire
Copy link
Contributor Author

mcmire commented Nov 18, 2022

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Packages published as '[current-version]-78f9eea'

@mcmire mcmire mentioned this pull request Nov 18, 2022
Merged
3 tasks
@Gudahtt

This comment was marked as resolved.

Sign in to view
@Gudahtt
Copy link
Member

Gudahtt commented Nov 19, 2022

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Packages published as '[current-version]-8d7e981'

@mcmire
Copy link
Contributor Author

mcmire commented Nov 21, 2022

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Packages published as '[current-version]-preview.ea702e4'

@mcmire mcmire marked this pull request as ready for review November 21, 2022 23:14
Gudahtt
Gudahtt approved these changes Nov 21, 2022
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

All of the changelogs/versions look good, and everything seems to work on the extension

@mcmire mcmire merged commit c340ab0 into main Nov 21, 2022
@mcmire mcmire deleted the release/34.0.0 branch November 21, 2022 23:53
vthomas13 pushed a commit that referenced this pull request Dec 2, 2022
@mcmire @Gudahtt @vthomas13
Release 34.0.0 (#960)
df05c72 
This release includes initial releases for all new packages.

Co-authored-by: Mark Stacey <[email protected]>
gantunesr pushed a commit that referenced this pull request Dec 8, 2022
@mcmire @Gudahtt @gantunesr
Release 34.0.0 (#960)
7f837d8 
This release includes initial releases for all new packages.

Co-authored-by: Mark Stacey <[email protected]>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@mcmire @Gudahtt @MajorLift
Release 34.0.0 (#960)
be32749 
This release includes initial releases for all new packages.

Co-authored-by: Mark Stacey <[email protected]>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
@mcmire @Gudahtt @MajorLift
Release 34.0.0 (#960)
35a9b40 
This release includes initial releases for all new packages.

Co-authored-by: Mark Stacey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcmire @Gudahtt