DetectedTokens getting reloaded from allDetectedTokens even after the tokens are imported for a chain and selectedAddress #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etNewAllTokensState while updating newAllDetectedTokens
mcmire
reviewed
Dec 13, 2022
jpuri
previously approved these changes
Dec 13, 2022
|
Code changes look good but +1 to @mcmire point about tests. |
adonesky1
reviewed
Dec 14, 2022
…g sure empty lists are not added just because used switched to an account or network
mcmire
reviewed
Dec 15, 2022
legobeat
reviewed
Dec 15, 2022
NiranjanaBinoy
dismissed stale reviews from adonesky1 and mcmire
via
b602a13
Merged
Gudahtt
added a commit
that referenced
this pull request
Dec 20, 2022
Changelogs: # `announcement-controller` ## [2.0.0] ### Changed - **BREAKING:** Migrate to BaseControllerV2 ([#959](#959)) - The announcement controller now extends `BaseControllerV2` rather than `BaseController`, which includes the following changes: - The constructor now accepts a single "args" object rather than positional parameters. - A restricted controller messenger instance must be passed into the constructor. - The controller configuration has been replaced by an `allAnnouncements` constructor parameter. - The following properties previously inherited from `BaseController` are no longer present: - `defaultConfig` - `defaultState` - `disabled` - `config` - `state` - The following methods previously inherited from `BaseController` are no longer present: - `configure` - `notify` - `subscribe` - `unsubscribe` - `update` - The `name` property is now readonly. # `assets-controllers` ## [3.0.1] ### Changed - Export `isTokenDetectionSupportedForNetwork` function ([#1034](#1034)) - Update `@metamask/contract-metadata` from 1.35.0 to 2.1.0 ([#1013](#1013)) ### Fixed - Fix token controller state updates ([#1015](#1015)) - Attempts to empty the list of "added", "ignored", or "detected" tokens were not saved in state correctly, resulting in that operation being undone after switching account or network.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
… tokens are imported for a chain and selectedAddress (#1015)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Changelogs: # `announcement-controller` ## [2.0.0] ### Changed - **BREAKING:** Migrate to BaseControllerV2 ([#959](#959)) - The announcement controller now extends `BaseControllerV2` rather than `BaseController`, which includes the following changes: - The constructor now accepts a single "args" object rather than positional parameters. - A restricted controller messenger instance must be passed into the constructor. - The controller configuration has been replaced by an `allAnnouncements` constructor parameter. - The following properties previously inherited from `BaseController` are no longer present: - `defaultConfig` - `defaultState` - `disabled` - `config` - `state` - The following methods previously inherited from `BaseController` are no longer present: - `configure` - `notify` - `subscribe` - `unsubscribe` - `update` - The `name` property is now readonly. # `assets-controllers` ## [3.0.1] ### Changed - Export `isTokenDetectionSupportedForNetwork` function ([#1034](#1034)) - Update `@metamask/contract-metadata` from 1.35.0 to 2.1.0 ([#1013](#1013)) ### Fixed - Fix token controller state updates ([#1015](#1015)) - Attempts to empty the list of "added", "ignored", or "detected" tokens were not saved in state correctly, resulting in that operation being undone after switching account or network.
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
… tokens are imported for a chain and selectedAddress (#1015)
MajorLift
pushed a commit
that referenced
this pull request
Oct 11, 2023
Changelogs: # `announcement-controller` ## [2.0.0] ### Changed - **BREAKING:** Migrate to BaseControllerV2 ([#959](#959)) - The announcement controller now extends `BaseControllerV2` rather than `BaseController`, which includes the following changes: - The constructor now accepts a single "args" object rather than positional parameters. - A restricted controller messenger instance must be passed into the constructor. - The controller configuration has been replaced by an `allAnnouncements` constructor parameter. - The following properties previously inherited from `BaseController` are no longer present: - `defaultConfig` - `defaultState` - `disabled` - `config` - `state` - The following methods previously inherited from `BaseController` are no longer present: - `configure` - `notify` - `subscribe` - `unsubscribe` - `update` - The `name` property is now readonly. # `assets-controllers` ## [3.0.1] ### Changed - Export `isTokenDetectionSupportedForNetwork` function ([#1034](#1034)) - Update `@metamask/contract-metadata` from 1.35.0 to 2.1.0 ([#1013](#1013)) ### Fixed - Fix token controller state updates ([#1015](#1015)) - Attempts to empty the list of "added", "ignored", or "detected" tokens were not saved in state correctly, resulting in that operation being undone after switching account or network.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 16854
When used to import the detectedTokens by calling
addTokenswe should clear thedetectedTokensandallDetectedTokens[chainId][selectedAddress]ie entry inallDetectedTokensfor that particular chainId and selectedAddress, otherwise the data from allDetectedTokens getting repopulated/reloaded into thedetectedtokenswhen the networkState or preferenceState changes.Edit: upon further inspection, we had to do the same clearing for allTokens and allIgnoredtokens as well.