Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changelog validation should fail if an "Uncategorized" heading is present anywhere #207

Open
MajorLift opened this issue Sep 26, 2024 · 0 comments
Open

Changelog validation should fail if an "Uncategorized" heading is present anywhere #207

MajorLift opened this issue Sep 26, 2024 · 0 comments
Labels
bug Something isn't working team-wallet-framework

Comments

@MajorLift
Copy link
Contributor

MajorLift commented Sep 26, 2024 •
edited
Loading

Example

  ## [8.0.2]

- ### Uncategorized
+ ### Changed

  - Bump TypeScript version to `~5.0.4` and set `moduleResolution` option to `Node16` ([#3645](https://github.com/MetaMask/core/pull/3645))
  - Bump `@metamask/utils` from `^9.0.0` to `^9.1.0` ([#4529](https://github.com/MetaMask/core/pull/4529))

MetaMask/core@cc09e4e#diff-e535ad89313f51c5a789b8f3abc6c1f8537bf7930087b9d6a9b16e6fdc28af89R12
@MajorLift MajorLift added bug Something isn't working team-wallet-framework labels Sep 26, 2024
@desi desi changed the title Changelog validation should fail if an "Uncategorized" heading is present anywhere other than the "Unreleased" section Changelog validation should fail if an "Uncategorized" heading is present anywhere Sep 26, 2024
@MajorLift MajorLift mentioned this issue Sep 26, 2024
Merged
4 tasks
MajorLift added a commit to MetaMask/core that referenced this issue Sep 26, 2024
@MajorLift
Fix "Uncategorized" heading left in changelog (#4740)
b120ada 
## Explanation

Introduced here:
https://github.com/MetaMask/core/pull/4544/files/6c61641d2987ccae098cff78b4d592e3e57fe1e2#r1686765290

## References

- See MetaMask/auto-changelog#207

## Changelog

No user-facing changes

## Checklist

- [ ] I've updated the test suite for new or updated code as appropriate
- [ ] I've updated documentation (JSDoc, Markdown, etc.) for new or
updated code as appropriate
- [ ] I've highlighted breaking changes using the "BREAKING" category
above as appropriate
- [ ] I've prepared draft pull requests for clients and consumer
packages to resolve any breaking changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working team-wallet-framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MajorLift