Add deprecated fields support #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephsumabat
commented
Oct 10, 2024
| @@ -418,6 +419,13 @@ data Options = Options | |||
| -- | |||
| -- This can be used with @omitFields = const Discard@ to ensure fields are | |||
| -- retained for client compatibility. | |||
| , deprecatedFields :: [(String, Maybe String)] | |||
There was a problem hiding this comment.
Maybe not necessary to have the comment as part of this since we could comment on the type directly
There was a problem hiding this comment.
EDIT: @tadfisher noted commenting on the type makes it show up as a doc comment which we dont want since the field is commented out
tadfisher
approved these changes
Oct 10, 2024
josephsumabat
force-pushed
the
joseph/add-deprecated-fields
branch
3 times, most recently
from
a65b78a to
e935786
Compare
josephsumabat
force-pushed
the
joseph/add-deprecated-fields
branch
from
e935786 to
f5abee8
Compare
tadfisher
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the concept of "deprecated fields" - fields which are still required by older clients but we no longer want to generate on newer ones.
These fields will be: