-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add record flattening feature from SDK #24
Comments
My team is looking for this flattening feature! I'm curious about at which level we can control the flattening? e.g. can we specify a specific stream, or a specific property to be flattened? |
Hi @teohm! As it currently stands, flattening is applied at a configurable level to all streams, and properties if they're at the right level. What you ask would be an interesting enhancement, though. Would you mind opening an issue if the feature is a hard requirement for you to use flattening? |
What is the progress on this feature request? |
@ashish-atidiv Record flattening is supported. You can see an example in https://github.com/MeltanoLabs/meltano-map-transform/pull/103/files#diff-ad41fb697ad72b7175f50fa33964f04d2535d1fe18a4502cb1e0f32b228971c5. Note that |
HI @edgarrmondragon |
Also @edgarrmondragon , can you tell how will the flattening logic treat arrays and list of dicts? |
meltano/sdk#1400 should be fixed by meltano/sdk#1939 |
@ashish-atidiv You can take a look at the snapshot in https://github.com/meltano/sdk/blob/0b2fe9e1cb740e5310692025812b8779b097b955/tests/snapshots/mapped_stream/flatten_all.jsonl, for example |
Closed by #103 |
In theory, this should be a simple addition, since the feature should be available in the underlying SDK.
The SDK source code for this feature's config is here:
https://github.com/meltano/sdk/blob/3998ac14918b6b2338851b8bb428485a9378ff49/singer_sdk/helpers/capabilities.py#L29-L43
In theory, we may be able to simply extend this repo's config with those additional options.
Related: docs improvement for SDK
Making this slightly more complex, it seems flattening is also not well documented in the SDK docs.
I didn't see any reference to those options in the SDK docs, so I'll log a separate issue on the SDK to properly document those.
UPDATE: now logged here:
flattening_enabled
andflattening_max_depth
meltano/sdk#717The text was updated successfully, but these errors were encountered: