Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Docker-compose command is incorrect #304

Closed
roborobs1023 opened this issue Sep 12, 2024 · 3 comments
Closed

[Bug] Docker-compose command is incorrect #304

roborobs1023 opened this issue Sep 12, 2024 · 3 comments
Assignees

Comments

@roborobs1023
Copy link

roborobs1023 commented Sep 12, 2024

What is the problem?

There is an error in the make docker-* commands.

Both commands currently have:

docker compose

this should be:

docker-compose

no need to check for version of docker-compose.

docker-compose up and docker-compose down works for all versions of docker.

Operating System

windows 10

Architecture Version (x86, x64, arm, etc)

x86

Steps to reproduce

run make docker-run

Relevant log output

make docker-run 
compose was unexpected at this time.
make: *** [Makefile:19: docker-run] Error 255
@roborobs1023 roborobs1023 changed the title [Bug] [Bug] Docker-compose command is incorrect Sep 12, 2024
@dannylwe
Copy link

If you are using the latest version of docker, you can install docker compose as a plugin, instructions and you will run docker compose up. But if you are using a slightly older version of docker and using the docker-compose executable, you will need to run docker-compose up. So it depends on your current version of docker and docker compose. Hope that helps.

@Ujstor
Copy link
Collaborator

Ujstor commented Sep 15, 2024

Docker make commands are only for Unix-like systems, they would not work on Windows. Maybe we can update the make templating to include Windows support as well.

# Create DB container
docker-run:
	@docker compose up

# Shutdown DB container
docker-down:
	@docker compose down

@Ujstor Ujstor mentioned this issue Sep 16, 2024
2 tasks
@Ujstor Ujstor self-assigned this Sep 16, 2024
@Ujstor
Copy link
Collaborator

Ujstor commented Sep 18, 2024

Resolved in #306

@Ujstor Ujstor closed this as completed Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants