Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sinkhorn distance implementation #19

Open
utkutpcgl opened this issue Jun 8, 2023 · 1 comment
Open

Sinkhorn distance implementation #19

utkutpcgl opened this issue Jun 8, 2023 · 1 comment

Comments

@utkutpcgl
Copy link

Thanks for the great contribution!

As mentioned in #17 (comment), the original sinkhorn implementation is different (page 11 of your paper):
image

Why is this the case?

@utkutpcgl
Copy link
Author

utkutpcgl commented Jun 14, 2023

By the way here is the original implementation u is updated first. u and v updates seem to be switched (confused?) in this paper:

https://github.com/gpeyre/SinkhornAutoDiff/blob/1e6c8c38974a325bb59cbc5b8cb6af5787b4f58d/sinkhorn_pointcloud.py#L63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant