Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

关于您的自用插件管理器 manager 可能会出现的问题 #10

Open
Jerry-FaGe opened this issue Oct 20, 2022 · 1 comment
Open

Comments

@Jerry-FaGe
Copy link

您好,我注意到您的插件管理器 manager 在执行 禁用/启用 指令的时候直接调用了 nonebot_plugin_managerplugin_manager.block_plugin() 方法但并没有验证当前禁用/启用的插件在当前会话是否可写,这应该会导致非超级用户的群管理、群主也可以开关 help 中灰色行(也就是 plugin.locked == True)的插件。

plugin_manager.block_plugin() 方法本身是并不带有可写权限检测的,nonebot_plugin_manager 也是在 npm block 的 Handle 中先判断了是否可写才去执行 block 。

@MeetWq
Copy link
Owner

MeetWq commented Oct 21, 2022

感谢提醒,我之后看一下

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants