Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task view: Keyboard navigation has many issues #59

Closed
AttemptToCallNil opened this issue Apr 21, 2021 · 0 comments
Closed

Task view: Keyboard navigation has many issues #59

AttemptToCallNil opened this issue Apr 21, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@AttemptToCallNil
Copy link
Contributor

Filing this so that I don't forget and others know. At the moment, the features implemented for the task view work not that badly with mouse navigation, but keyboard navigation (Tab key switching) is very bad and allows bypassing modal restrictions, including pressing buttons that should be covered by the modal, and opening multiple modals of the same "level" simultaneously. Additionally, the generator / task type lists use heavily restyled radio buttons wrapped in divs (as I couldn't pick a proper semantic equivalent to what they do) and don't work with the keyboard just about at all.

@RheingoldRiver RheingoldRiver added the bug Something isn't working label Apr 21, 2021
AttemptToCallNil added a commit to AttemptToCallNil/MAGE that referenced this issue Jun 14, 2021
Add focus indicators, fix elements that shouldn't be focusable,
fix the "no input" zone of "Enabled?" checkboxes, and extract the
"deferred focus" hack into its own method. Sigh.

Closes: MediaWikiAGE#59
@pcjcos pcjcos closed this as completed in 95a2fdb Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants