From 76d30ccb7cb20f659cce08e14e732bfb0a60153d Mon Sep 17 00:00:00 2001 From: Cheng Zhao Date: Fri, 5 Jan 2024 10:30:32 +0900 Subject: [PATCH] build: update GN build files for ngtcp2 PR-URL: https://github.com/nodejs/node/pull/51313 Reviewed-By: Luigi Pinca Reviewed-By: Michael Dawson Reviewed-By: James M Snell Reviewed-By: Jiawen Geng --- deps/ngtcp2/unofficial.gni | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/deps/ngtcp2/unofficial.gni b/deps/ngtcp2/unofficial.gni index 7665b5b0d1dce3..2c5890d71fe60a 100644 --- a/deps/ngtcp2/unofficial.gni +++ b/deps/ngtcp2/unofficial.gni @@ -38,6 +38,10 @@ template("ngtcp2_gn_build") { "_WINDOWS", "HAVE_CONFIG_H", ] + } else { + defines += [ + "HAVE_UNISTD_H", + ] } if (is_linux) { defines += [ @@ -53,9 +57,10 @@ template("ngtcp2_gn_build") { "nghttp3/lib/" ] - sources = gypi_values.nghttp3_sources + gypi_values.ngtcp2_sources + sources = gypi_values.nghttp3_sources + + gypi_values.ngtcp2_sources + + gypi_values.ngtcp2_sources_quictls if (node_use_openssl) { - sources += gypi_values.ngtcp2_sources_openssl deps = [ "../openssl" ] } @@ -63,6 +68,8 @@ template("ngtcp2_gn_build") { cflags_c = [ "-Wno-extra-semi", "-Wno-implicit-fallthrough", + # Remove after https://github.com/ngtcp2/ngtcp2/issues/1050 is fixed. + "-Wno-sometimes-uninitialized", ] } }