Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with ST3 Build 3103 #89

Closed
dschu-lab opened this issue Feb 9, 2016 · 34 comments
Closed

Incompatible with ST3 Build 3103 #89

dschu-lab opened this issue Feb 9, 2016 · 34 comments

Comments

@dschu-lab
Copy link

Hey there,

could you please update the packages.json to make this work with build 3103 again?

Thanks!

@andrewcaulfield
Copy link

Confirming that also have an issue with latest Sublime build 3103.

Cheers.

@GC-Mark
Copy link

GC-Mark commented Feb 9, 2016

+1

@djekl
Copy link

djekl commented Feb 9, 2016

Also having issues, seems to work if you uninstall then reinstall. But once you close and re-open Sublime it breaks again...

@GC-Mark
Copy link

GC-Mark commented Feb 9, 2016

I just reinstalled, and it works. It also works after a sublime restart, so not sure why it doesn't for you @djekl

@djekl
Copy link

djekl commented Feb 9, 2016

@GC-Mark Open a new window, then a project. It wont work then. I will see if I can get an example made up

@GC-Mark
Copy link

GC-Mark commented Feb 9, 2016

@djekl just tried that, still works 😕

@djekl
Copy link

djekl commented Feb 9, 2016

I only get 30 seconds on cloudy, so before I took the video I removed the package, and then installed it again. Closed all Sublime and it works as before. Then the video was started and you will see the issue cc:// @GC-Mark

http://cl.ly/3f3T2o1v3d1f

@GC-Mark
Copy link

GC-Mark commented Feb 9, 2016

Don't know if it makes a difference, but im using a different project switcher - https://github.com/randy3k/Project-Manager

P.S. What theme are you using, it looks awesome!

@rginnow
Copy link

rginnow commented Feb 9, 2016

+1 Broke when I upgraded my Sublime version to this new build.
Uninstalled and reinstalled, and it worked. Quit, reopened, and it still worked.
Even did a new window in a different Laravel project and it worked there too.

Not sure why, but I think it's a small issue to be looked into.

@djekl
Copy link

djekl commented Feb 9, 2016

@GC-Mark The theme I am using is called Material Theme. It has some bugs with regards to padding, but they are explained in the readme.

Here is my sublime settings file - https://gist.github.com/djekl/8eca76509c7d7915cc14

@Medalink
Copy link
Owner

Medalink commented Feb 9, 2016

Looks like they did not roll these out to the dev channel so I missed this before release. For now, use the dev release of 3102 as a workaround until I can get this fixed.

@stulogy
Copy link

stulogy commented Feb 9, 2016

I had this issue too, and rolled back to 3102 as suggested. I'm now getting this weird issue whereby if you put @if () statements inside attributes, then it breaks the rest of the display. See my screenshot.

screen shot 2016-02-09 at 2 26 04 pm

It didn't used to do this, it would just highlight everything in the attribute as yellow.

@cjaoude
Copy link

cjaoude commented Feb 9, 2016

Reinstalling the package helped. Can't say yet whether issues will crop back up.

@casenjo
Copy link

casenjo commented Feb 9, 2016

Tried removing and reinstalling the package but it didn't fix it. Downgraded to 3102 for now, will wait :)

@Skintillion
Copy link

Uninstall
Close Sublime
Open Sublime
Reinstall
Close Sublime
Open Sublime.

That worked ok for me.

@razikallayi
Copy link

Incompatible with ST3 Build 3103

+1

@Skintillion
Copy link

image

It works great.

@marwan2
Copy link

marwan2 commented Feb 10, 2016

The same issue also with me

@hollanbo
Copy link

same problem.

@harhoo
Copy link

harhoo commented Feb 10, 2016

Works fine for me; initially it didn't, so Iuninstalled and reinstalled with no success before realising that ST had lost all its syntax associations. So View > Syntax > Open all with current extension as and I was back in business.

@JPT62089
Copy link

Uninstall
Close Sublime
Open Sublime
Reinstall
Close Sublime
Open Sublime.

That worked ok for me.

This worked for me, too! Thanks, @Skintillion!

@ben-sharp
Copy link

Following @Skintillion instructions I am able to see my mark up nicely, however the javascript in the section at the bottom of my template now has zero highlighting whatsoever, not sure if this was always the case.

@stulogy
Copy link

stulogy commented Feb 10, 2016

Basic highlighting is working for me now. However when using conditionals it breaks the rest of the highlighting. See my screenshot. This was working before.

On Feb 10, 2016, at 5:47 PM, Benjamin Sharp [email protected] wrote:

Following @Skintillion instructions I am able to see my mark up nicely, however the javascript in the section at the bottom of my template now has zero highlighting whatsoever, not sure if this was always the case.


Reply to this email directly or view it on GitHub.

@nuhh
Copy link

nuhh commented Feb 11, 2016

As @stulogy said, I have same problem
error

@JayBizzle
Copy link
Contributor

@ryanmortier it doesn't work when your conditional starts within a HTML element

<div class="@if($something) active @endif">

@ryanmortier
Copy link

Oops, sorry I didn't see your comment before I deleted mine or I wouldn't have deleted my comment. Yes you're correct, using it inside an HTML attribute breaks for me too.

@cklmercer
Copy link

It works for me within an HTML element, but does not work for me within the quoted part of an attribute.

Works

<div class="col-md-8 text-content" @if($error) class="error" @endif>

Does Not Work

<div class="@if($error) error @endif">

@stulogy
Copy link

stulogy commented Feb 11, 2016

Agreed.

I think it’s the @ symbols that are throwing off the highlighter. Before this was never a problem, possibly because it ignored @ symbols.

On Feb 11, 2016, at 3:13 PM, Cody Mercer [email protected] wrote:

It works for me within an HTML element, but does not work for me within the quoted part of an attribute.

Works

Does Not Work
— Reply to this email directly or view it on GitHub.

@JayBizzle
Copy link
Contributor

I just created a pull request that hacks a fix for this issue. See #92

@RicardoEmpre
Copy link

For me it has problems with the vuejs line
@click="selectResource(resource)".
If you remove the @ or the parenthesis in that line, it works OK.

Also if you use v-on:click instead of @click it works ok.

untitled1

@estebanprimost
Copy link

@Skintillion 👍 Thanks.

@jago86
Copy link

jago86 commented Feb 19, 2016

Have the same issue @stulogy, @if breaks the rest of display

@matthewnance
Copy link

Just confirming - Dev build 3107 has not solved the issue even after a fresh install. Strange how inconsistent this seems to be, none of the aforementioned fixes have solved the issue on my end.

@JTallis
Copy link

JTallis commented Mar 28, 2016

I had this issue and I did what some others have done which is reinstalling the package and it seems to work so far for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests