Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Successfully upgraded to 1.3.13 #7

Open
JoeGrasso opened this issue Feb 20, 2015 · 2 comments
Open

Successfully upgraded to 1.3.13 #7

JoeGrasso opened this issue Feb 20, 2015 · 2 comments

Comments

@JoeGrasso
Copy link

Here are the changes I made to upgrade to 1.3.13:

I. Change the interpolateFn property:

     //1.3.13
          var parts = interpolateFn.expressions;          
     //1.2.x
         //var parts = interpolateFn.parts;

Per the docs:

$interpolate: due to 88c2193c, the function returned by $interpolate no longer has a .parts array set on it. Instead it has two arrays:

.expressions, -> an array of the expressions in the interpolated text. The expressions are parsed with $parse, with an extra layer converting them to strings when computed

.separators, -> an array of strings representing the separations between interpolations in the text. This array is always 1 item longer than the .expressions array for easy merging with it


II. Change the $templateCache's ng-pattern:

$templateCache.put
     ....

          // 1.2.x
          ng-pattern=\"/{{ field.schema.validation.pattern }}/\"

          // 1.3.13
          pattern="{{ field.schema.validation.pattern }}"
     ....

Note: I have not upgraded the code to reflect the new $validator for 1.3 form validation.

Hope this helps.

@JoeyHoutenbos
Copy link

@McNull can you please upgrade to Angular 1.3.x ?!

@spee65
Copy link

spee65 commented Mar 18, 2015

this will be great, The fixes abouve helps, but doesnt full functional

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants