You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Decryption/authentication of (D)TLS record encrypted with legacy CBC (that is CBC without EtM) includes checking the validity of the padding without leaking information about it, to avoid the Lucky 13 attack.
Currently this is done with code that looks constant-flow at the C level, but relies on arithmetic operators such as <= and *. Unfortunately, experience shows that some compilers translate even == using branches on some targets, which using only bit operations is usually more robust. A variety of idioms is documented for common operations.
This task is to modify in-place the existing padding checking code in ssl_decrypt_buf() to use only bit operations everywhere.
This may involve defining helper functions. In the development branch, helper function that may be of general use may be shared in a private module (declared in a header under library/). In the LTS branches since there is no such facility, those helper functions can just be static in ssl_tls.c.
Note: this task has a dependency on #3469, as we don't want to modify ssl_decrypt_buf() without negative tests.
The text was updated successfully, but these errors were encountered:
Decryption/authentication of (D)TLS record encrypted with legacy CBC (that is CBC without EtM) includes checking the validity of the padding without leaking information about it, to avoid the Lucky 13 attack.
Currently this is done with code that looks constant-flow at the C level, but relies on arithmetic operators such as
<=
and*
. Unfortunately, experience shows that some compilers translate even==
using branches on some targets, which using only bit operations is usually more robust. A variety of idioms is documented for common operations.This task is to modify in-place the existing padding checking code in
ssl_decrypt_buf()
to use only bit operations everywhere.This may involve defining helper functions. In the development branch, helper function that may be of general use may be shared in a private module (declared in a header under
library/
). In the LTS branches since there is no such facility, those helper functions can just be static inssl_tls.c
.Note: this task has a dependency on #3469, as we don't want to modify
ssl_decrypt_buf()
without negative tests.The text was updated successfully, but these errors were encountered: