Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use customized prebuildify-cross #35

Closed
MayamaTakeshi opened this issue Nov 12, 2022 · 1 comment
Closed

Use customized prebuildify-cross #35

MayamaTakeshi opened this issue Nov 12, 2022 · 1 comment

Comments

@MayamaTakeshi
Copy link
Owner

The official prebuildify-cross always will try to pull the image from ghcr.io even if it exists in the local docker repo.
Instead, we should modify our fork:
https://github.com/MayamaTakeshi/prebuildify-cross
to check if the image already exists and if yes, to use it.
This will avoid the need to push images to ghcr.io.

MayamaTakeshi pushed a commit that referenced this issue Nov 12, 2022
@MayamaTakeshi
Copy link
Owner Author

I have prepared a PR (prebuild/prebuildify-cross#16) but it might not be accepted so for now, we will install prebuildify-cross from our branch.

Sample usage:

takeshi@takeshi-desktop:~/src/git/MayamaTakeshi/sip-lab$ npx prebuildify-cross -i mayamatakeshi/sip-lab-jammy:latest -i mayamatakeshi/sip-lab-debian11:latest -t 16.0.0 --strip 

The above would generate and overwrite the same file as the platform is the same for both images:

takeshi@takeshi-desktop:~/src/git/MayamaTakeshi/sip-lab$ ls -l prebuilds/linux-x64/*
-rwxr-xr-x 1 takeshi takeshi 1784768 11月 13 08:28 prebuilds/linux-x64/node.abi93.node

but what matters is that it finished without errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant