From 5a9129b9c40ef7b418853553bebf4fbae26e7bb7 Mon Sep 17 00:00:00 2001
From: Matthias Beerens <3512339+Matthiee@users.noreply.github.com>
Date: Thu, 28 Dec 2023 20:50:38 +0100
Subject: [PATCH] Upgrade to .NET 8.0 (#109)

* Update to .NET 8.0

* Update github workflow

* Bump microsoft packages to 8.0.0

* Update other package dependencies

* Fix wrong type used in volume
---
 .github/workflows/dotnet.yml                  |  4 ++--
 .../FinancialModelingPrepApi.csproj           |  8 +++----
 .../Crypto/CyptoHistoricalPriceListings.cs    |  2 +-
 Tests/Tests.csproj                            | 22 +++++++++----------
 4 files changed, 18 insertions(+), 18 deletions(-)

diff --git a/.github/workflows/dotnet.yml b/.github/workflows/dotnet.yml
index fa7b6de..65186cb 100644
--- a/.github/workflows/dotnet.yml
+++ b/.github/workflows/dotnet.yml
@@ -16,9 +16,9 @@ jobs:
       with: 
         fetch-depth: 0
     - name: Setup .NET
-      uses: actions/setup-dotnet@v2
+      uses: actions/setup-dotnet@v4
       with:
-        dotnet-version: 7.x
+        dotnet-version: 8.x
     - name: Restore dependencies
       run: dotnet restore
     - name: Build
diff --git a/FinancialModelingPrepApi/FinancialModelingPrepApi.csproj b/FinancialModelingPrepApi/FinancialModelingPrepApi.csproj
index 2479e26..e1df3e5 100644
--- a/FinancialModelingPrepApi/FinancialModelingPrepApi.csproj
+++ b/FinancialModelingPrepApi/FinancialModelingPrepApi.csproj
@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
 	<PropertyGroup>
-		<TargetFrameworks>net6.0;net7.0</TargetFrameworks>
+		<TargetFrameworks>net7.0;net8.0</TargetFrameworks>
 		<RootNamespace>MatthiWare.FinancialModelingPrep</RootNamespace>
 		<PackageRequireLicenseAcceptance>False</PackageRequireLicenseAcceptance>
 		<GeneratePackageOnBuild>True</GeneratePackageOnBuild>
@@ -27,9 +27,9 @@
 
 	<ItemGroup>
 		<PackageReference Include="Bert.RateLimiters" Version="1.0.15" />
-		<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="7.0.0" />
-		<PackageReference Include="Microsoft.Extensions.Http" Version="7.0.0" />
-		<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="7.0.1" />
+		<PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
+		<PackageReference Include="Microsoft.Extensions.Http" Version="8.0.0" />
+		<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="8.0.0" />
 		<PackageReference Include="MinVer" Version="4.3.0">
 			<PrivateAssets>all</PrivateAssets>
 			<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
diff --git a/FinancialModelingPrepApi/Model/Crypto/CyptoHistoricalPriceListings.cs b/FinancialModelingPrepApi/Model/Crypto/CyptoHistoricalPriceListings.cs
index 6c4fa56..1cc3f31 100644
--- a/FinancialModelingPrepApi/Model/Crypto/CyptoHistoricalPriceListings.cs
+++ b/FinancialModelingPrepApi/Model/Crypto/CyptoHistoricalPriceListings.cs
@@ -25,7 +25,7 @@ public class CryptoHistoricalPricePeriodListing
         public decimal Close { get; set; }
 
         [JsonPropertyName("volume")]
-        public long Volume { get; set; }
+        public double Volume { get; set; }
     }
 
     public class CyptoHistoricalPriceDailyListing
diff --git a/Tests/Tests.csproj b/Tests/Tests.csproj
index 5afeea4..5c9ed54 100644
--- a/Tests/Tests.csproj
+++ b/Tests/Tests.csproj
@@ -1,22 +1,22 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-	  <TargetFrameworks>net7.0</TargetFrameworks>
+	  <TargetFrameworks>net8.0</TargetFrameworks>
 
     <IsPackable>false</IsPackable>
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Divergic.Logging.Xunit" Version="4.2.0" />
-    <PackageReference Include="Microsoft.Extensions.Configuration" Version="7.0.0" />
-    <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="7.0.0" />
-    <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="7.0.0" />
-    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="7.0.0" />
-    <PackageReference Include="Microsoft.Extensions.Logging" Version="7.0.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.7.2" />
-    <PackageReference Include="Moq" Version="4.20.69" />
-    <PackageReference Include="xunit" Version="2.5.2" />
-    <PackageReference Include="xunit.runner.visualstudio" Version="2.5.3">
+    <PackageReference Include="Divergic.Logging.Xunit" Version="4.3.0" />
+    <PackageReference Include="Microsoft.Extensions.Configuration" Version="8.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="8.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="8.0.0" />
+    <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0" />
+    <PackageReference Include="Microsoft.Extensions.Logging" Version="8.0.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" />
+    <PackageReference Include="Moq" Version="4.20.70" />
+    <PackageReference Include="xunit" Version="2.6.4" />
+    <PackageReference Include="xunit.runner.visualstudio" Version="2.5.6">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>