Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the EbmlDocVersion constraints when checking/adding mandatory elements #277

Open
robUx4 opened this issue Feb 26, 2024 · 0 comments
Open
Labels
api-break breaks the API (e.g. programs using it will have to adjust their source code)

Comments

@robUx4
Copy link
Contributor

robUx4 commented Feb 26, 2024

Although we don't do that (yet ?) in Matroska, it's possible to add new mandatory elements without a default value. Such elements should not be written when writing an older version of the doctype. They should also not be automatically added to an EbmlMaster by default.

This will require passing the EbmlDocVersion in more places. Or probably introduce a ShouldRead function which could do more than just checking the profile, for example allow dummy elements or not. Just like ShouldWrite is used to skip the elements with a default value.

@robUx4 robUx4 added the api-break breaks the API (e.g. programs using it will have to adjust their source code) label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api-break breaks the API (e.g. programs using it will have to adjust their source code)
Projects
None yet
Development

No branches or pull requests

1 participant