VaultsSecretsRemove incorrectly reorders directories to be removed

[aryanjassal]

Describe the bug

In the handler, VaultsSecretsRemove performs grouping, which would result in the order of files being changed. This is done to ensure all files from a single vault is removed in one vault commit, but doesn't align with how Unix rm works.

Instead, we want to preserve the order of the files while removing them in a single commit. This is blocked by Polykey#821.

To Reproduce

1. Call VaultsSecretsRemove with directory paths and mixed vault names
2. VaultsSecretsRemove groups them by vault, changing the order

Expected behavior

The order should be preserved, still ensuring the operation finishes in one commit.

Screenshots

Platform

• Device: Dell Precision 3480
• OS: NixOS 24.05
• Version 0.12.0

Additional context

• Blocked by Polykey#821

Notify maintainers

@aryanjassal

[linear]

ENG-450 `VaultsSecretsRemove` incorrectly reorders directories to be removed