Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update client domain structure #563

Closed
7 tasks done
tegefaulkes opened this issue Oct 10, 2023 · 2 comments · Fixed by #567
Closed
7 tasks done

Update client domain structure #563

tegefaulkes opened this issue Oct 10, 2023 · 2 comments · Fixed by #567
Assignees
@addievo
Labels
development Standard development r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management r&d:polykey:supporting activity Supporting core activity

Comments

@tegefaulkes
Copy link
Contributor

tegefaulkes commented Oct 10, 2023 •
edited by CMCDragonkai
Loading

Specification

During #552 the agent domain was rolled into the nodes domain at src/nodes/agent. The agent domain was restructured during this time as well.

  1. All the handlers were updated to use default exports.
  2. All the handlers were updated to use arrow functions.
  3. The ServerManifest was moved into the index.ts.
  4. The caller definitions were moved into nodes/agent/callers.
  5. The caller definitions were split into separate files. (I don't like this change, it means that each caller which can be defined in a single line need to be spread across 60+ files.) I should check with @CMCDragonkai to see if it's required.
  6. clientManifest was moved into nodes/agent/callers/index.ts.
  7. errors.ts, types.ts and utils.ts are in nodes/agent directory now.

Pretty much try to structure the client domain like nodes/agent directory. If anything is unclear, make a comment here asking about it.

Additional context

Tasks

  • 1. All the handlers were updated to use default exports.
  • 2. All the handlers were updated to use arrow functions.
  • 3. The ServerManifest was moved into the index.ts.
  • 4. The caller definitions were moved into nodes/agent/callers.
  • 5. The caller definitions were split into separate files. (I don't like this change, it means that each caller which can be defined in a single line need to be spread across 60+ files.) I should check with @CMCDragonkai to see if it's required.
  • 6. clientManifest was moved into nodes/agent/callers/index.ts.
  • 7. errors.ts, types.ts and utils.ts are in nodes/agent directory now.
@tegefaulkes tegefaulkes added the development Standard development label Oct 10, 2023
@tegefaulkes tegefaulkes mentioned this issue Oct 10, 2023
Merged
10 tasks
@addievo
Copy link
Contributor

addievo commented Oct 11, 2023

@CMCDragonkai whats the go on

The caller definitions were split into separate files. (I don't like this change, it means that each caller which can be defined in a single line need to be spread across 60+ files.) I should check with @CMCDragonkai to see if it's required.

@addievo addievo linked a pull request Oct 11, 2023 that will close this issue
Client Domain Structure of Callers and Handlers should match Agent Callers and Handlers #567
Merged
15 tasks
@addievo addievo mentioned this issue Oct 11, 2023
Merged
15 tasks
@tegefaulkes
Copy link
Contributor Author

One thing I forgot to mention in the spec. The handler names went from XYZHandler to XYZ.

@CMCDragonkai CMCDragonkai added r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management r&d:polykey:supporting activity Supporting core activity labels Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@addievo addievo

Labels
development Standard development r&d:polykey:core activity 1 Secret Vault Sharing and Secret History Management r&d:polykey:supporting activity Supporting core activity
Milestone
No milestone
3 participants
@CMCDragonkai @tegefaulkes @addievo