Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break up PolykeyAgent and PolykeyClient classes based on domain models #102

Closed
robert-cronin opened this issue Sep 16, 2020 · 2 comments · Fixed by #118
Closed

Break up PolykeyAgent and PolykeyClient classes based on domain models #102

robert-cronin opened this issue Sep 16, 2020 · 2 comments · Fixed by #118
Assignees
Labels
development Standard development
Milestone

Comments

@robert-cronin
Copy link
Contributor

Right now there are 2 large files; one for the agent and one for the client. This is not very cohesive and needs to be split into separate files based on some good domain modelling.

@robert-cronin
Copy link
Contributor Author

PolykeyClient is now superseded by a codegen client. The agent file remains one big file however

@robert-cronin
Copy link
Contributor Author

This is probably less ideal to break up into different sub files since the class needs to conform to the interface generated by gRPC.
I tried doing it initially, but it just didn't really seem to make it better.

@robert-cronin robert-cronin added this to the PolyKey MVP milestone Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development
Development

Successfully merging a pull request may close this issue.

1 participant