-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Specify --network
with URL such as testnet.polykey.com
#97
Comments
This is already done right? Didn't @amydevs fix this a while back? |
--network
with URL such as testnet.polykey.com
--network
with URL such as testnet.polykey.com
Can you verify? |
Nope, not actually done yet. The CLI option still needs to be modified to take the URL rather than the network name. |
I've made the change on staging, I now need to make the change in Orchestrator as well. Otherwise the deployment of seednodes will be set to the wrong hostname |
So CLI PR and Orchestrator PR then? Need to reopen. |
Oh is the Polykey-CLI done here then? 3525826. Orchestartor PR could be done separately - but should be kept track here. |
This has already been done in Orchestrator, I just pushed a commit because it was a 1 line change: https://github.com/MatrixAI/Orchestrator/commit/935bd07cbe447d30046638c5a8f931c39773c813 |
Specification
Currently the network option takes either
mainnet
ortestnet
, these are hard-coded into the config file and resolved to the URLsmainnet.polykey.com
andtestnet.polykey.com
respectively.We should change this to use the
mainnet.polykey.com
ortestnet.polykey.com
directly. So when selecting the network option when starting polykey it's either specified with the option as---network mainnet.polykey.com
with the default asmainnet.poykey.com. The ENV variable will likewise be the same
PK_NETWORK=mainnet.polykey.com`.This will slightly reduce the complexity while allowing any properly set up network URL to be used.
Additional context
Tasks
Polykey
config.js.mainnet.polykey.com
.The text was updated successfully, but these errors were encountered: