Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify --network with URL such as testnet.polykey.com #97

Closed
tegefaulkes opened this issue Jan 17, 2024 · 7 comments
Closed

Specify --network with URL such as testnet.polykey.com #97

tegefaulkes opened this issue Jan 17, 2024 · 7 comments
Assignees
Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices

Comments

@tegefaulkes
Copy link
Contributor

Specification

Currently the network option takes either mainnet or testnet, these are hard-coded into the config file and resolved to the URLs mainnet.polykey.com and testnet.polykey.com respectively.

We should change this to use the mainnet.polykey.com or testnet.polykey.com directly. So when selecting the network option when starting polykey it's either specified with the option as ---network mainnet.polykey.com with the default as mainnet.poykey.com. The ENV variable will likewise be the same PK_NETWORK=mainnet.polykey.com`.

This will slightly reduce the complexity while allowing any properly set up network URL to be used.

Additional context

Tasks

  1. Remove network names and information from the Polykey config.js.
  2. Update the CLI option to take and parse hostnames.
  3. Update the CLI option to default to mainnet.polykey.com.
  4. Update any tests that depend on this change.
  5. Update any CI jobs that depend on this change.
Copy link
Contributor Author

This is already done right? Didn't @amydevs fix this a while back?

@tegefaulkes tegefaulkes changed the title Specify --network with URL such as testnet.polykey.com Specify --network with URL such as testnet.polykey.com Apr 11, 2024
@CMCDragonkai
Copy link
Member

Can you verify?

@tegefaulkes
Copy link
Contributor Author

Nope, not actually done yet. The CLI option still needs to be modified to take the URL rather than the network name.

@amydevs amydevs closed this as completed Jun 20, 2024
@amydevs amydevs reopened this Jun 20, 2024
@amydevs amydevs self-assigned this Jun 20, 2024
Copy link
Contributor

amydevs commented Jun 20, 2024

I've made the change on staging, I now need to make the change in Orchestrator as well. Otherwise the deployment of seednodes will be set to the wrong hostname

@amydevs amydevs closed this as completed Jun 20, 2024
@CMCDragonkai
Copy link
Member

So CLI PR and Orchestrator PR then? Need to reopen.

@CMCDragonkai CMCDragonkai reopened this Jun 20, 2024
@CMCDragonkai
Copy link
Member

CMCDragonkai commented Jun 20, 2024

Oh is the Polykey-CLI done here then? 3525826.

Orchestartor PR could be done separately - but should be kept track here.

@amydevs amydevs closed this as completed Jun 21, 2024
Copy link
Contributor

amydevs commented Jun 21, 2024

This has already been done in Orchestrator, I just pushed a commit because it was a 1 line change:

https://github.com/MatrixAI/Orchestrator/commit/935bd07cbe447d30046638c5a8f931c39773c813

@CMCDragonkai CMCDragonkai added the r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Standard development r&d:polykey:core activity 4 End to End Networking behind Consumer NAT Devices
Development

No branches or pull requests

3 participants