-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update node2nix with the upstream fixes to building bin links #21
Comments
It might be a good idea to create our own toolchain here and completely leave It seems that if we were to generate the final executable, we would just put that into the Nix package, rather than leaving around node source code as the Nix package. That would make it far more similar to other Nix packages that just have the compiled executable left. The only reason to package anything for Nix is the final application, not the NodeJS library, since Node libraries are not distributed in Nix, they are just source code, not shared objects. Although Python libraries are distributed in Nix atm, and I've worked on that before. The reason that works is due to the way the final Python environment can easily load all the python packages directly from the The equivalent Anyway, this means instead of trying to fit node2nix in, we could discard it entirely, and instead focus on building the final executable that would then work in Nix environment and distribute that. The final executable must however be Nix's nodejs, and not just any nodejs, since that nodejs has to be bind to Nix C++ provided shared objects. This also means |
This is going to be relevant to Polykey-CLI factoring out. MatrixAI/Polykey#268 |
I believe we already have the latest However we don't know if it works yet since a full complete build hasn't succeeded yet. I'll be moving this issue into |
Ok so our It's possible if we try to do a full build, it might break as we are still doing it. We have to see if the new node2nix 1.11.1 (as per nixpkgs pin supplied in pkgs.nix) does the job already and in which case we can remove the If it is no longer needed, then we can also remove |
I think node2nix is abandoned. The nixpkgs upstream isn't updating it. And as per the above, the only reason we are using it is to create an "application", but we might as well just focus on creating the executable using I think I'm going to get rid of node2nix. To do this, I'll need to use The problem is fetching all the dependencies. Community https://discourse.nixos.org/t/future-of-npm-packages-in-nixpkgs/14285/25 says:
|
https://discourse.nixos.org/t/announcing-js2nix-scale-your-node-js-project-builds-with-nix/23111/12 - so js2nix and buildNpmPackage. Will try js2nix since this seems relevant to us. |
Specification
The new node2nix finally fixes the bin links problems: svanderburg/node2nix#302
It's time to check to see if this works for us and then remove our hack in
default.nix
Additional context
Tasks
The text was updated successfully, but these errors were encountered: