Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git tag (9.3.0) does not match package.json version (9.2.0) #44

Open
krisrok opened this issue Jul 8, 2022 · 4 comments
Open

Git tag (9.3.0) does not match package.json version (9.2.0) #44

krisrok opened this issue Jul 8, 2022 · 4 comments

Comments

@krisrok
Copy link

krisrok commented Jul 8, 2022

Hard to keep track of the right version this way.

Also there are even more confusing some zombie files in this directory. Maybe they can be cleaned up?
https://github.com/Mathijs-Bakker/Extenject/blob/master/UnityProject/Assets/Plugins/Zenject/

especially
https://github.com/Mathijs-Bakker/Extenject/blob/master/UnityProject/Assets/Plugins/Zenject/Version.txt (saying 9.1.0)
and another package.json:
https://github.com/Mathijs-Bakker/Extenject/blob/master/UnityProject/Assets/Plugins/Zenject/package.json (saying 0.0.1)

@loverainstm
Copy link

another problem is the file name too long for compositestaller in test folder

@tsgcpp
Copy link

tsgcpp commented Jul 24, 2022

@loverainstm

another problem is the file name too long for compositestaller in test folder

Is it for a limit of 260 characters?

https://stackoverflow.com/questions/22575662/filename-too-long-in-git-for-windows

@ImInfenix
Copy link

This could be easily solved, but what should the version in package.json be ? Should it be 9.3.1 (current last release) or 9.3.2 as the HEAD of this repo is currently not resolved ? @Mathijs-Bakker Do you have any guideline to follow for this ? It is true that it's a bit confusing in the editor view.

image
.

@Mathijs-Bakker
Copy link
Owner

Yes, it should be current release.

I think it would be best if the semver is automated. As it's easy to forget to do this manually.

Need to check if there's a Github workflow for writing the semver into the project file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants