-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Git tag (9.3.0) does not match package.json version (9.2.0) #44
Comments
another problem is the file name too long for compositestaller in test folder |
Is it for a limit of 260 characters? https://stackoverflow.com/questions/22575662/filename-too-long-in-git-for-windows |
This could be easily solved, but what should the version in package.json be ? Should it be 9.3.1 (current last release) or 9.3.2 as the HEAD of this repo is currently not resolved ? @Mathijs-Bakker Do you have any guideline to follow for this ? It is true that it's a bit confusing in the editor view. |
Yes, it should be current release. I think it would be best if the semver is automated. As it's easy to forget to do this manually. Need to check if there's a Github workflow for writing the semver into the project file. |
Hard to keep track of the right version this way.
Also there are even more confusing some zombie files in this directory. Maybe they can be cleaned up?
https://github.com/Mathijs-Bakker/Extenject/blob/master/UnityProject/Assets/Plugins/Zenject/
especially
https://github.com/Mathijs-Bakker/Extenject/blob/master/UnityProject/Assets/Plugins/Zenject/Version.txt (saying 9.1.0)
and another package.json:
https://github.com/Mathijs-Bakker/Extenject/blob/master/UnityProject/Assets/Plugins/Zenject/package.json (saying 0.0.1)
The text was updated successfully, but these errors were encountered: